Date: Thu, 19 Oct 2023 17:25:47 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274595] net-p2p/monero-cli: new build option added Message-ID: <bug-274595-7788-wDPhIyWeFv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-274595-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-274595-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274595 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open Assignee|ports-bugs@FreeBSD.org |fuz@FreeBSD.org --- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> --- Thank you for catching that. As per =C2=A7 13.14.4 Porter's Handbook, -mar= ch=3Dnative must not be enabled by default. Your patch is good, but please rename the option to NATIVE (this is the standard name in ports for such an option, you can omit NATIVE_DESC as it is provided in bsd.options.desc.mk) and make it enable -march=3Dnative with th= e flag being off by default. I think it might be possible to avoid the patch to CMakeLists.txt by using NATIVE_CMAKE_ON=3D -DARCH=3Dnative NATIVE_CMAKE_OFF=3D -DARCH=3Ddefault but I'm not super familiar with cmake, so please check for yourself. Also please increment PORTREVISION by only 1 for each update. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274595-7788-wDPhIyWeFv>