From nobody Sun Sep 10 07:31:05 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rk1k65QDcz4s3Z8 for ; Sun, 10 Sep 2023 07:31:26 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-23.consmr.mail.gq1.yahoo.com (sonic311-23.consmr.mail.gq1.yahoo.com [98.137.65.204]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rk1k56j3qz3Tpt for ; Sun, 10 Sep 2023 07:31:25 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=OyiQJDzc; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.65.204 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694331083; bh=KCvBMF0pqUTKBW2rqm2632SPFqJgWu2xcNGGdeGIGr4=; h=From:Subject:Date:Cc:To:References:From:Subject:Reply-To; b=OyiQJDzc2m5l8PS3UVDr3KzgIhVd/4bfUPEykxfZLs0E90M6pRGWv6ZUgitKS5zoXNDo4h9IPoYp2VSla9eCiCfy5Fzf1ooZn8J5cPgMyJDDQPIYmQLqWh9HHXXqh4at7Pa6nAuYfIoXBiEpgnkt0nZ374Z8oS2PuOtrNGR1BTsuwTzfYWxUeuyr8u8yjTZCu9Gf+K87xnWFOwocaDQSWH+iLUgbDQBYdoMEmKZj3CQz5MoL/hhocBLRHBpIXPyCpDMKRH0JiPfvfhJR6ZuOQGrSuQKcVziRMu+vZ24kUWaen7u/jlKBAr25mHmDMD8eJglCvfXLqMGEKjQsaGYLGQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694331083; bh=hBBEKiPFBMd0Yzko7Q4eGKxVcDPGdV14Oz0Mx3Y/2Zl=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=ZubkpRWWlKwteVrRzt191mtd/2UiiXXTe+W9rPBfSWZYTZUrpd/aJ2fL3QJVYN+XcI4NxwVKrYoOh0ncXKCS5f4bQlr1NWB4HFc+iqeDIlR2Vaf6x+a4jWkVBMnGbWe7Cu3h0qvToYQHBBVWBCqNpvWP/99t0QxtPVIOEfQigOURk9rUG+lscnhmWTVgc1G3eYLWfP1UR65nPPwWhb4n8OaxyF3/JUz+1et0QVQsCTGLwWWx8fPPDyaqGzWXdvc5YB1ZUU9kzr3IJjuOtbl+GczY8gzl82L1FVOxU9sD/Lo/2keffBQvkUknncoh58F7S4WnGKo8j3ywgMBg3sI+Pw== X-YMail-OSG: rdHHi_MVM1kQ6oBd89oSNpd99LqEUfMnA_IUFgwpJIon9y1QvQ_Y1amJ79vrsAX oPI7zj0eQTKsdVnddnQPPnoEmoGTSDX4uPk6APmh55LyAH8eho9SPMupLZY_lf25Q1PiVk0cWDT9 uOq_6gwyGRDOoVbccn9DXNCabU4S.VaeZiKJnhO9S7oq2w566dIkUzm8HGGRurJLMLSwPefevWDZ MOhkJOwN.ROwDCj.9wnjednTBSnKNSHr23..5KIZ9Pqbffr_1eKsK.XjtMjukvY7Kv91ZLvDrdRk 4zBT_l8serg8YEJIs2QQkVUCIQMdHr42EOHUq0MZBSq9NZvjEl.wj68SnQGLleFyDJKulCQMQHVL 2KFXGXyCK1S.0ZZ1QB4FKJPrIze.g92Cvzm6_Wn74BBD9E51McETa2lQlbp5sVARZRWjzjgfbT_W I4TZ.Kb.8KZ_mBo9joa.avwWmLJ2ihqHdCDdo4.rVWE8gtG73R4rrYtvix355KBSiaaWeMlv8Vsu sfkbVu3ztY53zeGMorrK.oRjDmBQqa0W3ABphh7X48DwZKpd_XCfbrBB9l_mxPEgsuEeX_kg9BgI 0Cg28TjKE82TfoDPKr6SSLNHYdHI7p9RnSNA6CL6x9FPTBSMvwKk0RMO7vF.qyuTkKZc9aXABLAl UU_YWSyDTvIx1mJYtl7edx8ZYhzEol7K8BuDzp_OBwv_r0X7g_2AKvSPpB7Mh1UgS7bIHtrAqulQ X1x.E9dNNj163nZdLGXyz9IimSwvQbzzuseXGLz0FPsmMYGdWwao69illBR6a6hBlTWH0l_z_QZo pMkEz4cOrInncCwAhxZeeGoikICFw0MMg9mP7p.6GDv3tII1s8KQl3qMz5tC0Yla1gF8VGzwAh1Y 6YS73c3WQX.g_M310VO1UQKA6I3T3fTPS.JsN2uGtn_WIqbGvEybYsP9iJDtwedoD3p0GBtRAg9q VqprJhVYCBiKlmsAcnSklkCmRaGgJro6WsK6szGAziXtCHfnCR24B9HMquzcdTRVuj8C2NU5zHzY vG3TzWiGdBrz1m3WtSqY9V9S9WjwtWicRWuh_1KIgg3f7VuRVj1dqcopw04Eg0s7C5dUdo4DZiiy RKgArx6saU5RcghY1zwbzzA0DgqbJ_C3.u5.vwxD8oaO12OO6Sx5MRrC4UA8aGJs58E12W5g.3HQ ldgecMvD3QcsGXTzKFU05DXQOzGjHZE9n6sFlJYmykiV7C4F40.PdS7z.rxtOUFZZhhdZTrVPbZo qOMVaaJnfGyvS3z2LehaRzJ63NIfiYh9_QQYk92VIPZ0SDUskiwcClsJh.Il46Z2wTM8wWzvVa_Y GIwz0.ezia_UHEJGJoIhlezkeOwXd8rhdBfJvbx2q7dzZQZ4VWPEv.S_Jpdga.Ryy6FLAZHBJit8 brfP3GvNbv_qwOD_NnqkunrO_bFZaAmSsbyPM.o1Iyv8EgWJ5aiR8kPplGrRfOeE.PeTp8V01h7v agqYPJemg2dvnHX1IPkJXTSCD1_l7nKaPjPm3tTCKn_BRg8TGBMKV5n4pStgXSKicWxxW4V7Q1yv cpfQzFDWD1oZmhNUcY.3iFCZkMyhKdqq7GcCtNcM38lx710V9KLPmhRFlNB4Lt4v3LArfzCB_5TV 9F59jHuAPrVxiao2sghbXxYP_qBlMAbO8gb6UhvEe1U0FyH2ODs4K13ikJm03AVD6aUVEQnBjAgu 8cC4uKgmu58f_GoZUVCjCAMrLSipFwe68RsnwmKTJSKFI0JUnzPyC2sJRG2yj77PvuqMLUBoaHb0 r1LfZXS1nR5xI22w8C_C5z2YLt7_T52OEpP4jALqHbbm75WVocmGZvi3T41DK1j2BcykhmwpLtnD T0JBjtkyv5v3Z581wts.4kodWCHun8bItXLvVPYXn1bcM6NXr2yZoC.CCl_tBeGIpdwkteEnprlb C0udG9WRWv144k67zIMCm1hfK6f2qXFMumR6lEtWr_Purt8b49RC3H8LIgW33bmASlg2kJEMllNH 9YbyKgymQBB18W9JMgHSty4saJB3XoefFcFzBiVk5RkGoAzfSixlrj7p3kcB7jsVwK1LajwwQwNe ak749ee.cl4UalsF1sXjBG6X0xhB.kTmuaOBt9UzMYhhNJ8hvIhJuH6lwqApapuZ7NqC5ppw5CIB 9aErzyHpig8tqBXrPN6OmMXsobJ0DaBKRovrWGssHHfN9GSsvtaMTVR.Mo49Rt6gm5tmpLYSBGdb 8rWktTqrbIuXJ0rjswZ2Pu0Fas9sKMn7IouPaZtO5otDwzlHWFm3sP5BDT57Fxlx3chnCbMrjkLW U0KGAaKeRiiQ- X-Sonic-MF: X-Sonic-ID: 013dcad6-56d3-434c-9dd9-8a31b4d942c6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Sun, 10 Sep 2023 07:31:23 +0000 Received: by hermes--production-bf1-865889d799-sjjww (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5d9bd5503bf1d429fdfe2520d9091de2; Sun, 10 Sep 2023 07:31:18 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Looks like the kyua zfs tests likely are not used on aarch64 or other contexts with unsigned char Message-Id: <96C2F8F3-D3F0-48FC-BEEC-E3C983BD680A@yahoo.com> Date: Sun, 10 Sep 2023 00:31:05 -0700 Cc: Current FreeBSD , FreeBSD-STABLE Mailing List , freebsd-arm To: Martin Matuska , Alexander Motin , Pawel Jakub Dawidek , Glen Barber X-Mailer: Apple Mail (2.3731.700.6) References: <96C2F8F3-D3F0-48FC-BEEC-E3C983BD680A.ref@yahoo.com> X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.46 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.96)[-0.961]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.204:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.204:from]; DKIM_TRACE(0.00)[yahoo.com:+]; TO_DN_ALL(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4Rk1k56j3qz3Tpt kyua tests that use the: /usr/tests/sys/cddl/zfs/bin/mkfile program like so (for example): mkfile 500M /testpool.1861/bigfile.0 (which should be valid) end up with mkfile instead reporting: Standard error: Usage: mkfile [-nv] [e|p|t|g|m|k|b] ... which prevent the kyua test involved from working. Turns out this is from expecting char to be always signed (so a -1 vs. 255 distinction, here in an aarch64 context): . . . (gdb) list 179 /* Options. */ 180 while ((ch = getopt(argc, argv, "nv")) != -1) { 181 switch (ch) { 182 case 'n': 183 nofill = 1; 184 break; 185 case 'v': (gdb) print ch $16 = 255 '\377' (gdb) print/x -1 $17 = 0xffffffff (gdb) print/x ch $18 = 0xff . . . With the mix of unsigned and signed it ends up being a 0xffu != 0xffffffffu test, which is always true. So the switch is reached as if a "-" prefix was present (that is not). Then the "option" is classified as invalid and the usage message is produced. Apparently no one had noticed. That, in turn, suggests a lack of inspected testing on aarch64, powerpc64, powerpc64le, armv7, powerpc, and powerpcspe. That, in turn, suggests that kyua test inspection for the likes of aarch64 is not historically a part of the release process for openzfs or for operating systems that include openzfs. === Mark Millard marklmi at yahoo.com