From owner-svn-ports-head@FreeBSD.ORG  Mon Nov  4 14:15:54 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 41EB3EFD;
 Mon,  4 Nov 2013 14:15:54 +0000 (UTC)
 (envelope-from feld@FreeBSD.org)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id BDE7027F6;
 Mon,  4 Nov 2013 14:15:53 +0000 (UTC)
Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44])
 by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id C783B20697;
 Mon,  4 Nov 2013 09:15:52 -0500 (EST)
Received: from web3 ([10.202.2.213])
 by compute4.internal (MEProxy); Mon, 04 Nov 2013 09:15:52 -0500
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=message-id:from:to:cc:mime-version
 :content-transfer-encoding:content-type:subject:date:in-reply-to
 :references; s=smtpout; bh=sR7IYfuHXQ5zUzh5qigR0nJAawE=; b=mjCq+
 OOzcN8KBBKa2taW2ycZZkrd14ZbwAclvN4AYuV6wvUzpjye7BMEBjSqsliIA6qZB
 XaltnhnoOACXyZ15UFSqfwAUKeqpLhZ1OJRrzXtvJnyLP864L0x8JrPf+Y5tduZc
 KO1ADRA3kpYWFpL0/ufQnCgJlh/yT+375U71yo=
Received: by web3.nyi.mail.srv.osa (Postfix, from userid 99)
 id A181810B3BF; Mon,  4 Nov 2013 09:15:52 -0500 (EST)
Message-Id: <1383574552.17263.42707017.6BE762CA@webmail.messagingengine.com>
X-Sasl-Enc: dtdIoRuUT6VgtiJzjH3sJuqG9ztyR7lW0lwhYwDdodxr 1383574552
From: Mark Felder <feld@FreeBSD.org>
To: Eitan Adler <eadler@freebsd.org>, Tijl Coosemans <tijl@freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-Mailer: MessagingEngine.com Webmail Interface - ajax-d4893488
Subject: Re: svn commit: r332567 - head/graphics/apvlv
Date: Mon, 04 Nov 2013 08:15:52 -0600
In-Reply-To: <CAF6rxgn4Bj9J+re5V9yZNNZFTyX5o8EWDG7+N4WpJEGbK24Egg@mail.gmail.com>
References: <201311030036.rA30aXLv016213@svn.freebsd.org>
 <20131103201410.2f95dc09@kalimero.tijl.coosemans.org>
 <CAF6rxgn4Bj9J+re5V9yZNNZFTyX5o8EWDG7+N4WpJEGbK24Egg@mail.gmail.com>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Nov 2013 14:15:54 -0000



On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl@freebsd.org> wrote:
> 
> > but now PTHREAD_CFLAGS is always empty
> 
> Which is always a mistake.  PTHREAD_CFLAGS should be replaced with
> -pthread
> 
>  so you can remove that line and PTHREAD_LIBS is always
> > -pthread.
> 
> As should this.
> 

Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
PTHREAD_LIBS into portlint as well.

I'm not 100% sure I understand the changes you're proposing -- I'm
getting caught up on the wording. Is this diff what you're suggesting?

--- Makefile    (revision 332703)
+++ Makefile    (working copy)
@@ -22,8 +22,8 @@
                -DDOCDIR=${DOCSDIR} \
                -DAPVLV_WITH_UMD=OFF \
                -DAPVLV_WITH_TXT=ON
-CFLAGS+=       ${PTHREAD_CFLAGS}
-LDFLAGS+=      ${PTHREAD_LIBS}
+CFLAGS+=       -pthread
+LDFLAGS+=      -pthread
 
 OPTIONS_DEFINE=        DJVU WEBKIT