From owner-cvs-all Fri Mar 23 11:51:21 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 86E6937B71B; Fri, 23 Mar 2001 11:51:13 -0800 (PST) (envelope-from joerg@FreeBSD.org) Received: (from joerg@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f2NJpDA18258; Fri, 23 Mar 2001 11:51:13 -0800 (PST) (envelope-from joerg) Message-Id: <200103231951.f2NJpDA18258@freefall.freebsd.org> From: Joerg Wunsch Date: Fri, 23 Mar 2001 11:51:13 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net if_spppsubr.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG joerg 2001/03/23 11:51:13 PST Modified files: sys/net if_spppsubr.c Log: (MFC candidate, see below). When we get an Open event in stopped state, experience shows that this is usually means we've somehow missed a previous Down event. This has occasionally bitten people for the IPCP layer with ISDN, apparently a previously aborted IPCP negotiation must have caused this. As a bandaid, we quickly pretent a Down event by advancing to starting state; this effectively implements the `restart' option mentioned in RFC 1663. While i'm not yet fully convinced this is the best thing to do (and is fully compliant with RFC 1661), i've seen a number of reports here on the German mailing lists where people have been bitten by the previous behaviour which usually causes quickly looping ISDN reconnects (thus loss of money...), and where just this patch fixes the problem. For this, i'd even like to see it MFC'd if possible. Submitted by: Helmut Kreft Revision Changes Path 1.65 +15 -1 src/sys/net/if_spppsubr.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message