From owner-svn-src-head@freebsd.org Thu Apr 6 23:19:49 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CACA9D32C68; Thu, 6 Apr 2017 23:19:49 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st13p35im-asmtp001.me.com (st13p35im-asmtp001.me.com [17.164.199.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9EA4AD36; Thu, 6 Apr 2017 23:19:49 +0000 (UTC) (envelope-from tsoome@me.com) Received: from process-dkim-sign-daemon.st13p35im-asmtp001.me.com by st13p35im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OO000C00GKYGA00@st13p35im-asmtp001.me.com>; Thu, 06 Apr 2017 23:19:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=4d515a; t=1491520788; bh=kiTmRfson7KtERb9dvWTXsWyORRuZnDkZe4bvy6DlTk=; h=From:Message-id:Content-type:MIME-version:Subject:Date:To; b=mFX81Fx5dLsEiu2JqX0S22pxEPXrH7vb1SP3tgeMn1wmlpgVXrrlLZFnR/vuftUE5 LoEY+p4g9AcplXCnyOH/PB/8pXOatWQD82ncY9yToh6h8dudTSZExlS+sygY0m4rlh 2lIaqmC+/E5tbZjdoKoe47889sgTuhQTnst/pH1zWLVTbEDEMiuWg8UMNW+zkM4hpF b/5mpd3ccUBHGIU9R3tWDNeHhr+oqyPipBfXYnL2gUvuvTUMAwq9NKW+IUFnOmMtih QS8NH5vBfTV8zKfqr4wYxS2WiGUHREbWE6ApUMasN0xae2RjoENkjhOtHQyzm8SY5F WOXs9/KXSyRqA== Received: from icloud.com ([127.0.0.1]) by st13p35im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OO000H4OGSXN630@st13p35im-asmtp001.me.com>; Thu, 06 Apr 2017 23:19:48 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-06_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1701120000 definitions=main-1704060192 From: Toomas Soome Message-id: MIME-version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs Date: Fri, 07 Apr 2017 02:19:44 +0300 In-reply-to: <3EFCAFB8-25E6-41A0-A1CF-26B4785FB482@me.com> Cc: Toomas Soome , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Bryan Drewery References: <201704061817.v36IHT8i088712@repo.freebsd.org> <06998a2b-fa92-500a-cdf6-5057ca96a76f@FreeBSD.org> <3EFCAFB8-25E6-41A0-A1CF-26B4785FB482@me.com> X-Mailer: Apple Mail (2.3273) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 23:19:49 -0000 > On 6. apr 2017, at 22:48, Toomas Soome wrote: >=20 >=20 > Yes, sorry, I did miss the sparc version, looking on it=E2=80=A6. I did quick and =E2=80=9Cdirty=E2=80=9D first round, but really need = some help there, please check and comment: = https://reviews.freebsd.org/D10302 =20= >=20 > rgds, > toomas >=20 >=20 >> On 6. apr 2017, at 22:41, Bryan Drewery wrote: >>=20 >> On 4/6/2017 11:17 AM, Toomas Soome wrote: >>> Author: tsoome >>> Date: Thu Apr 6 18:17:29 2017 >>> New Revision: 316585 >>> URL: https://svnweb.freebsd.org/changeset/base/316585 >>>=20 >>> Log: >>> loader: zfs reader should check all labels >>>=20 >>> The current zfs reader is only checking first label from each = device, however, >>> we do have 4 labels on device and we should check all 4 to be = protected >>> against disk failures and incomplete label updates. >>>=20 >>> The difficulty is about the fact that 2 label copies are in front of = the >>> pool data, and 2 are at the end, which means, we have to know the = size of >>> the pool data area. >>>=20 >>> Since we have now the mechanism from common/disk.c to use the = partition >>> information, it does help us in this task; however, there are still = some >>> corner cases. >>>=20 >>> Namely, if the pool is created without partition, directly on the = disk, >>> and firmware will give us the wrong size for the disk, we only can = check >>> the first two label copies. >>>=20 >>> Reviewed by: allanjude >>> Differential Revision: https://reviews.freebsd.org/D10203 >>=20 >>=20 >> Something seems wrong in make universe: >>=20 >>> cc -isystem = /usr/obj/sparc64.sparc64/root/git/freebsd/tmp/usr/include = -L/usr/obj/sparc64.sparc64/root/git/freebsd/tmp/usr/lib = -B/usr/obj/sparc64.sparc64/root/git/freebsd/tmp/usr/lib = --sysroot=3D/usr/obj/sparc64.sparc64/root/git/freebsd/tmp = -B/usr/obj/sparc64.sparc64/root/git/freebsd/tmp/usr/bin -O2 -pipe = -DLOADER_DISK_SUPPORT -DLOADER_UFS_SUPPORT -DLOADER_CD9660_SUPPORT = -DLOADER_ZFS_SUPPORT = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../zfs = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../../cddl/boot/zfs = -DLOADER_GZIP_SUPPORT -DLOADER_NET_SUPPORT -DLOADER_NFS_SUPPORT = -DLOADER_TFTP_SUPPORT -DBOOT_FORTH = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../ficl = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../ficl/sparc64 = -DLOADER_DISK_SUPPORT -DLOADER_GPT_SUPPORT -DLOADER_MBR_SUPPORT = -DLOADER_GELI_SUPPORT -I/root/git/freebsd/sys/boot/ficl = -I/root/git/freebsd/sys/boot/ficl/sparc64 = -I/root/git/freebsd/sys/boot/ficl/../common = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../common -I. = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../ofw/libofw/ = -I/root/git/freebsd/sys/boot/sparc64/zfsloader/../../../../lib/libstand/ = -I/root/git/freebsd/sys -ffreestanding -std=3Dgnu99 -static -nostdlib -o = zfsloader locore.o main.o metadata.o vers.o boot.o commands.o console.o = devopen.o interp.o interp_backslash.o interp_parse.o ls.o misc.o = module.o panic.o load_elf64.o reloc_elf64.o dev_net.o disk.o part.o = crc32.o interp_forth.o = /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/sparc64/zfsloader/../..= /ficl/libficl.a = /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/sparc64/zfsloader/../..= /zfs/libzfsboot.a = /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/sparc64/zfsloader/../..= /ofw/libofw/libofw.a -lstand >>> --- zfsloader --- >>> = /usr/obj/sparc64.sparc64/root/git/freebsd/sys/boot/sparc64/zfsloader/../..= /zfs/libzfsboot.a(zfs.o): In function `zfs_probe': >>> zfs.c:(.text+0x7f28): undefined reference to `ldi_get_size' >>> *** [zfsloader] Error code 1 >>=20 >>=20 >>=20 >> --=20 >> Regards, >> Bryan Drewery >>=20 >=20 >=20