Date: Thu, 2 Jun 2011 15:12:58 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r222273 - in head: gnu/usr.bin gnu/usr.bin/grep tools/build/options usr.bin usr.bin/grep Message-ID: <20110602131257.GV1002@acme.spoerlein.net> In-Reply-To: <201105250104.p4P14DLb092748@svn.freebsd.org> References: <201105250104.p4P14DLb092748@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 25.05.2011 at 01:04:13 +0000, David E. O'Brien wrote: > Author: obrien > Date: Wed May 25 01:04:12 2011 > New Revision: 222273 > URL: http://svn.freebsd.org/changeset/base/222273 > > Log: > Build and install a BSD licensed grep. > If WITH_BSD_GREP is not set, it will be 'bsdgrep' and GNUgrep will be > '[ef]grep'. Otherwise, BSD-grep will be the grep family, and GNUgrep > will be 'gnugrep'. > > Discussed with: brooks > > Modified: > head/gnu/usr.bin/Makefile > head/gnu/usr.bin/grep/Makefile > head/tools/build/options/WITH_BSD_GREP > head/usr.bin/Makefile > head/usr.bin/grep/Makefile > > Modified: head/gnu/usr.bin/Makefile > ============================================================================== > --- head/gnu/usr.bin/Makefile Wed May 25 00:34:25 2011 (r222272) > +++ head/gnu/usr.bin/Makefile Wed May 25 01:04:12 2011 (r222273) > @@ -27,9 +27,7 @@ _groff= groff > .endif > .endif > > -.if ${MK_BSD_GREP} != "yes" > _grep= grep > -.endif > You should have done the same here as in usr.bin/Makefile, i.e. get rid of the ${_grep} variable completely. Just saying ... Uli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110602131257.GV1002>