From owner-svn-src-all@freebsd.org Tue Aug 21 18:26:56 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5062107B7E4; Tue, 21 Aug 2018 18:26:55 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 900D090D3E; Tue, 21 Aug 2018 18:26:55 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 73D635A9F13; Tue, 21 Aug 2018 18:26:49 +0000 (UTC) Date: Tue, 21 Aug 2018 18:26:49 +0000 From: Brooks Davis To: mmel@freebsd.org Cc: Kyle Evans , Brooks Davis , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337978 - in head/libexec/rtld-elf: . aarch64 arm mips powerpc powerpc64 riscv Message-ID: <20180821182649.GB25927@spindle.one-eyed-alien.net> References: <201808171619.w7HGJlZe015255@repo.freebsd.org> <29d939de-108e-c7c4-b4b6-4a7772dca2eb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 18:26:56 -0000 --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 20, 2018 at 08:08:01PM +0200, Michal Meloun wrote: >=20 > On 20.08.2018 18:02, Kyle Evans wrote: > > On Mon, Aug 20, 2018 at 11:00 AM, Michal Meloun wrote: > >> > >> On 17.08.2018 18:19, Brooks Davis wrote: > >>> Author: brooks > >>> Date: Fri Aug 17 16:19:47 2018 > >>> New Revision: 337978 > >>> URL: https://svnweb.freebsd.org/changeset/base/337978 > >>> > >>> Log: > >>> Rework rtld's TLS Variant I implementation to match r326794 > >>> > >>> The above commit fixed handling overaligned TLS segments in libc's > >>> TLS Variant I implementation, but rtld provides its own implementat= ion > >>> for dynamically-linked executables which lacks these fixes. Thus, > >>> port these changes to rtld. > >>> > >>> Submitted by: James Clarke > >>> Reviewed by: kbowling > >>> Testing byL kbowling (powerpc64), br (riscv), kevans (armv7) > >>> Obtained from: CheriBSD > >>> Sponsored by: DARPA, AFRL > >>> Differential Revision: https://reviews.freebsd.org/D16510 > >>> > >>> Modified: > >>> head/libexec/rtld-elf/aarch64/rtld_machdep.h > >>> head/libexec/rtld-elf/arm/rtld_machdep.h > >>> head/libexec/rtld-elf/mips/rtld_machdep.h > >>> head/libexec/rtld-elf/powerpc/rtld_machdep.h > >>> head/libexec/rtld-elf/powerpc64/rtld_machdep.h > >>> head/libexec/rtld-elf/riscv/rtld_machdep.h > >>> head/libexec/rtld-elf/rtld.c > >>> > >> This commit breaks TLS handling for (at least) armv7. Can you please > >> revert it until I will be able to identify where is problem? > >> In my case, the libc _ThreadRuneLocale symbol is not zero on program s= tart. > >> > >=20 > > Interesting that I didn't hit this on my armv7 test > >=20 >=20 > No idea yet. For me, it breaks all ctype (isspace()..) related function. > Originally, I found that bash port gets broken. Its funny if shell takes > 'a' as non-alphanumeric character, 'x' as whitespace, ... > Anyway, give me a while - I need to write testcase because bas is too > complex for effective debugging. This commit isn't fundamentally bad, it > works for jemalloc thread local variables so I think that only some edge > case (tbss handling is my candidate) is affected. Reverted in r338149. It's quite surprising to me that the system would boot in this state.=20 Is there anything non-default about your build environment? -- Brooks --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJbfFloAAoJEKzQXbSebgfAHrgIAJvHU+VBhWa21+LmgDw0hFaN oX1XDxyloBLwdn2T0Efk5fKH8JLMnT1WnHoB3gRHtwzY3aNQzoKNeLtMlD6RNad3 qHzXSep3LNxn9eDKjKklsBehoFDnqtKjxXLRazKHzSxUgd7KY44M1S0m344sd6SR GQAap+236yvDPV7SDHtaqqD6iEUNxsf0Ud5EJtm+iW00cchKQuEy6ZPX8MllkQZ0 3y1UDn9FSjiagcroI7E9RDNVYoAoZhGi7wbfVpcZx/1bSIakK1z3H4H53mOsxBTQ LSjc4t+j8s8muIVNLkFeDDH6wzUjqLd06EEKNAWOX7lQCKj2czHtQKUD9bkZTVE= =UhCV -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb--