From owner-freebsd-current@FreeBSD.ORG  Wed Apr 27 07:02:51 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4573616A4CE; Wed, 27 Apr 2005 07:02:51 +0000 (GMT)
Received: from 62-15-211-171.inversas.jazztel.es
	(62-15-211-171.inversas.jazztel.es [62.15.211.171])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EE50B43D60; Wed, 27 Apr 2005 07:02:49 +0000 (GMT)
	(envelope-from josemi@freebsd.jazztel.es)
Received: from redesjm.local (orion.redesjm.local [192.168.254.16])
	j3R72ZAp024098;	Wed, 27 Apr 2005 09:02:35 +0200 (CEST)
	(envelope-from josemi@redesjm.local)
Received: from localhost (localhost [[UNIX: localhost]])
	by redesjm.local (8.13.3/8.13.3/Submit) id j3R72VuM001218;
	Wed, 27 Apr 2005 09:02:31 +0200 (CEST)
	(envelope-from josemi@redesjm.local)
From: Jose M Rodriguez <josemi@freebsd.jazztel.es>
To: freebsd-current@freebsd.org
Date: Wed, 27 Apr 2005 09:02:30 +0200
User-Agent: KMail/1.8
References: <200504261143.55195.josemi@redesjm.local>
	<200504270052.33158.josemi@redesjm.local> <426F2562.2090008@freebsd.org>
In-Reply-To: <426F2562.2090008@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200504270902.31464.josemi@redesjm.local>
X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.30.0.7;
	VDF: 6.30.0.116; host: antares.redesjm.local)
cc: Sam Leffler <sam@errno.com>
cc: Tim Kientzle <kientzle@freebsd.org>
cc: Jose M Rodriguez <josemi@freebsd.jazztel.es>
cc: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: rigth crc32 implementation
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2005 07:02:51 -0000

El Mi=E9rcoles, 27 de Abril de 2005 07:38, Tim Kientzle escribi=F3:
> Jose M Rodriguez wrote:
> > El Mi=C3=A9rcoles, 27 de Abril de 2005 00:19, Marcel Moolenaar=20
escribi=C3=B3:
> >>On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote:
> >>>Note also there is CRC32 code of this sort in WEP and TKIP crypto
> >>>modules in the net80211 support.
> >>
> >>Given the seperation of crc32() into crc32_raw() and crc32(), with
> >>either crc32() only or otherwise both functions inlined, are there
> >>any obstacles preventing the 802.11 code from using the ones in
> >>src/sys/libkern?
> >
> > at last, sys/dev/if_sbni have another implementation of what seems
> > to be a crc32 alg.
>
> Be a little careful, please.  There are very many
> different, incompatible "32-bit CRCs."  There are
> just a few popular ones, so you can often combine
> functions, but not always.
>

I'm getting this.

I'll try to do some test and notes.

I think that a regression test may show what is and what is not the=20
ether CRC-32.

At the moment, I'll go private with
=2D CRC_INIT, CRC_DO, CRC_GET macros
=2D An implementation in the way of crc32(), crc32_raw(), but avoiding=20
symbol collission.

And go to libkern through the macros if doable.

=2D-
  josemi