From owner-freebsd-hackers@freebsd.org Thu Oct 29 00:23:15 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 04E6C453544; Thu, 29 Oct 2020 00:23:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CM5kp0QPgz3Wg1; Thu, 29 Oct 2020 00:23:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x529.google.com with SMTP id t14so911181pgg.1; Wed, 28 Oct 2020 17:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=gTPriKkDBs743Kd6p/2WnduW+quoeLNNqe4GX7yg9Jg=; b=uqU2VgoPVeH/lbJgOTtTH0hEJUKEfHWyEDc/gpvym8FS5v8EuZ64YL4LzbN8tYNDLq nviR8zN3aQiWEI8O914FqwNWNB8MU7YkTk8A+Vdaac5sgLHDxBIpDYWYswOweKsnVvzk 8e+XSOZaexCSuVD6Qw8VgvFx6GH+Kf7O4t8F3BIVP4sq1XU1M/7vY19KNGyh3l2GciYi zXC0aN3ogo6rgLzMhir6e5Fka0e5IzgML0uoXaVPA6sFwBqPbmoWVadtSuaj/X9FCND4 Cmxa0X9pjeyOD1n6KoPDu+t+GwDxaYCc6cJup+0dRwiQ0D/+SzYhSfSFUxWK2sykGyLo 7NGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=gTPriKkDBs743Kd6p/2WnduW+quoeLNNqe4GX7yg9Jg=; b=ANsshz7K3LsJ9bzzLcVbdntJLeOvn6tSzN8nfRyHyL/fM9p4GimrGd9xWzOVmd2qKa uG1oeUJ/y/YlGvB254m9VDaBmChgxU6l0ta7322HQEyKhdhRGhXjDiUiVnEqV9v7s4jn mN5SqwHQ0y7gYjM33rsbFJUs33nZZCUl1L9l+osPSP03+rXXbzhkeBJmrd3HKYxuikRm KOmhMO+LsawML2Vc7IZioW3SWOarh7rOSLiILmE70UrbFwNFSj+O7MhSVAIgSnA+fPqC xvWz6Gh4LPvsqc6SV40NW0TpHH6o8bpX60JMkwIO3CeJE6bKXwLOOxO3T6XlS/VERsaW q+ew== X-Gm-Message-State: AOAM533bFBbtg0xLs8biixZRNIFnppOUPdz0i8Xgr7WTAzmcW+BgniWu hW6VINwJlEbIXhus0doeFOlW9irAw/uz7g== X-Google-Smtp-Source: ABdhPJw87UBZoE1WSqvyYjno04Tmr9G/5/rUUEGTkfMldXdDL8W29d8Yab6eaZtS9LuzPjHbk47YPQ== X-Received: by 2002:a63:5644:: with SMTP id g4mr1772501pgm.145.1603930990409; Wed, 28 Oct 2020 17:23:10 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id l3sm525891pju.28.2020.10.28.17.23.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2020 17:23:09 -0700 (PDT) From: Enji Cooper Message-Id: <0217233F-9E0D-47EC-AAAA-1C19551C2FF9@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: Testing with lua/atf-lua reviews Date: Wed, 28 Oct 2020 17:23:08 -0700 In-Reply-To: Cc: freebsd-testing@freebsd.org, FreeBSD Hackers To: Kyle Evans References: X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Rspamd-Queue-Id: 4CM5kp0QPgz3Wg1 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=uqU2VgoP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::529 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.48)[-0.481]; RECEIVED_SPAMHAUS_PBL(0.00)[73.19.52.228:received]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.01)[-1.008]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.01)[-1.014]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::529:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-testing,freebsd-hackers] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 00:23:15 -0000 > On Oct 24, 2020, at 9:09 AM, Kyle Evans wrote: >=20 > Hello! >=20 > I've just put up for review some work I've done to allow us to write > tests in lua, primarily intended to test the lua libs we're writing. > Please feel free to add yourself or drop in for some commentary: >=20 > - https://reviews.freebsd.org/D26928 - atf-lua(1)/atf-lua(3) itself > - https://reviews.freebsd.org/D26929 - Build glue for atf-lua > - https://reviews.freebsd.org/D26930 - atf.tests.mk infrastructure for > adding tests > - https://reviews.freebsd.org/D26931 - Build glue for atf-lua tests > - https://reviews.freebsd.org/D26932 - jail(3lua) tests, as a sample >=20 > Note that D26932 has an additional hard dependency on the libjail > bindings and some additions I've made to them, notably: D26080, > D26756, and D26927. Hi Kyle, I realize that I haven=E2=80=99t been fully in the loop lately due to = time and focusing on other things, but I=E2=80=99m not fully onboard = with this approach. In particular, one of the things that jmmv was more onboard with was = limiting atf, not extending it, and I agree with his desire to not do = that. Furthermore, why isn=E2=80=99t this using the luaunit framework instead = and the support being added to kyua to support luaunit: = http://lua-users.org/wiki/UnitTesting = ? There are a ton of caveats = with ATF that I would rather not support longer than necessary and = having to teach folks how to use a homegrown test infrastructure instead = of leveraging an open source test infrastructure which is supported by = an external group. Doing the latter makes maintenance easy for us and = improves the utility of the support better. Thank you, -Enji=