From owner-freebsd-embedded@FreeBSD.ORG Tue Oct 15 17:18:32 2013 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E1DDEBB6 for ; Tue, 15 Oct 2013 17:18:31 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm11-vm8.bullet.mail.gq1.yahoo.com (nm11-vm8.bullet.mail.gq1.yahoo.com [98.136.218.175]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A5F96284C for ; Tue, 15 Oct 2013 17:18:31 +0000 (UTC) Received: from [98.137.12.188] by nm11.bullet.mail.gq1.yahoo.com with NNFMP; 15 Oct 2013 17:18:24 -0000 Received: from [98.136.164.75] by tm9.bullet.mail.gq1.yahoo.com with NNFMP; 15 Oct 2013 17:18:24 -0000 Received: from [127.0.0.1] by smtp237.mail.gq1.yahoo.com with NNFMP; 15 Oct 2013 17:18:24 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1381857504; bh=NdhNmx3IqtvMh04IBWfL+jCmlh4DbRv5GuL8KajlduQ=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=3+a6+binwuDo7E6XM0UcyCAiMMRRmwaASuvfyoL6EJOXkef4L7bMa4kcDXex8VYCx7kxNv9atZp6dpP5yR/pF4kL/snONkHTWfPzKqOGgAAXYxiKBYsveTkja8aA5j1783t0OX1Mtvqqt5DyRxcvCEMNuiJsNs5bQQuD/T7nw5M= X-Yahoo-Newman-Id: 939645.97997.bm@smtp237.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: hf21tp0VM1krQc746Y3FI.XnD.xzAeurJELZEjoKIjFIvmv O1eyaT.2EQsoEjyskwUk1lLx8mUUM_QDiWQ5Y8CYUfgyho9CS4peOsO28sb3 srL5FSLOvrbKrg7oDAo3dzCchHFy51JDGLSrLvAacQFShcNcC8p8gerdYIlK xom35An4nZ_Z54_X3McwyjHnVN5M3wv74LHFIqQTgHEUUelSr_LAc.8cGtaI CNNwIPaQLkRjqBw4HKQ7Cfn3PtPYjjGR_AXkuW7T.d_4LCDYxLENdjfgkxVZ 0ScrWCVZtJqcxpkR1oPzljN6gwpAnZSwQC3RV.srw3SVQjHPAAWEEJJbhQ5E rG8HTkcatsGTg1phpwGhJG6zme5Qkbtw1X0YT7KnBxbRYxS9gFa8Z6l64g2B oUDrOaSbxr9bPQBCHKXhyxsa4FEGiUKqUfOFZDjXTXjGogPQTRHwXGPK7b4o 4ohkCCdOn673l9p1xVv3pkwNLCTkhrj5yDzAoC_ndgyHVcLXLlj7JiUKxjk7 mSf7N.p34kBx_isAHw9KVm_VEWPm9nDBjrE8nHj2_fve5plNB2fpJoTE8eg5 TUA-- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [10.73.128.143] (sean_bruno@209.131.62.121 with ) by smtp237.mail.gq1.yahoo.com with SMTP; 15 Oct 2013 17:18:24 +0000 UTC Subject: Re: makefs(8) proposed changes [repost from fs@] From: Sean Bruno To: John-Mark Gurney In-Reply-To: <20131015170403.GO56872@funkthat.com> References: <1380730546.1619.47.camel@localhost> <1381853252.2682.0.camel@localhost> <20131015170403.GO56872@funkthat.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-RijlfbmQ6LrY8ZmI8DOg" Date: Tue, 15 Oct 2013 10:18:23 -0700 Message-ID: <1381857503.1855.0.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: freebsd-embedded@freebsd.org X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 17:18:32 -0000 --=-RijlfbmQ6LrY8ZmI8DOg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Tue, 2013-10-15 at 10:04 -0700, John-Mark Gurney wrote: > Sean Bruno wrote this message on Tue, Oct 15, 2013 at 09:07 -0700: > > Is this patch going to break non "device" makefs calls? e.g. if I want > > to create an image file and not use a loopback device? >=20 > If the image file is zero bytes, then yes, it will break it... as the > read will return a short value (possibly zero) ... Why not add some > error checking and if the read doesn't read enough, write the > remaining bytes? If there is a failure from the read, the operation > should fail... >=20 yep, sounds good. =20 does this "proof of concept" code seem to make sense to you? sean --=-RijlfbmQ6LrY8ZmI8DOg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSXXjVAAoJEBkJRdwI6BaHCz4H/1u2U6ESp4Q+yJSMeCWe4kZB rnYX098BLqf1iZ5YZfCPRSbRRBl8npsi43Cq5PzDdw1Y4wbKF6l75rHkuehx7c7d sgKhmaOcY/NPZkGl0r1HBaV+L4tBQUTBJsgx3/FYq2yllr3GPdbIbx2Rg3TEEbmG qNxnXOTiqYEVSv2ro4aTlqmBKDcjdxmE/5+fUxGzNMBOHNnwGqB1lOoFQiL1OX9b 8xb4+Op91+aEMCrCvu+Qm8sF/kx3OyG4nszfOx2UujK7doD/PQkgKj0CFzW826gs ZTigPqzeu2fzbn0OJVQhsacpsV4VsW377vwdUmm9Rivcaijnyz5giHUvNGDyaW0= =naaq -----END PGP SIGNATURE----- --=-RijlfbmQ6LrY8ZmI8DOg--