From nobody Tue Sep 2 06:38:35 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cGGKY4QxWz66ZLQ; Tue, 02 Sep 2025 06:38:41 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cGGKY2xj1z3pkQ; Tue, 02 Sep 2025 06:38:41 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756795121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiM7KN4DMVPe/fWFKo9lX1iOrODdtfImAcgKeTXmCxw=; b=EJKn3uHAJAcVbKYnis3Mtr1S6Mfqt7pCxZJpKfKsJSyRGD8QemTUMpbC4wKBIWohLCuqrd orZTnO51JkmWsgoxSSWmSSZG8Pgcb8kEsa1LO558vLjI+nHYvBYpTqfrq0WZj1ykcKkows UPodwNFZORuiOXpyY0q1F/xIckCOHvZ+SCNWUnAAWZpX95pOeatutfthlaJRzLLtkS+x5Y 6e+5L2PMQhwTP2CmLcHY1LpAfvp/al9L7WFRU5fVCEnQHXE9AGFmw/aKhM4NtsDdlPIejK pVdjGRxDkK5bM4aB+pYv7ko7XkqAyacy0zW3qkpdBGJLJ7gDfjOZ2FK39i3Efw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756795121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiM7KN4DMVPe/fWFKo9lX1iOrODdtfImAcgKeTXmCxw=; b=YTdLQhkKBYGNxEHVx2a6heN4T1wQqda9HQ9+KfKM9rQQsdxRtKwHRUyJBldcudt9h1DNyB +aCscQW0RXrqEvIFVmlZntpOmy+juOoNKZPsJS6hD08SxAs20P2q3AkedCMHWRa1Elwo+s HEMX862XZOEVRQVT8bGrP4S3/bwiEZY5nBO//AJbpiPUTSyaxNfeOXHSCje99649KsWOWi 3/M/sACEjm9kwCYwuTIupWirqvgdxRBsft/9h5v7rb5m5PNNUKVqfgPGbECS2cMaENIjuI 9VJiOyfFjWKZUkquDhier2Z+pJy0F1ovDdtIokipUBOf43bpELKvv1pnEyx1mQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756795121; a=rsa-sha256; cv=none; b=Q2+9bSc+QGAom+8nnX4QatAQ8dQIgNmg4PYXcVceEYRZ7KRGpPbMoFpbldo5WAeJky3w5H wxu+D+iVtxk2L7Y/01Zwi8QMsopazZfxhgK+KiQl6I4ZfzF8JUqJA15Z2yy14yia0rXN7N 2CYhzTi+N3H70cg0XBaDLr1RBQQbyvEyUEtoYgVmMxIUI+aXGxYVYRwjmgHuN+HJKeRikn Qlgd3vsRAmSNKtFJ7X78BkzmeSwSGhXzxAjXQM7R+tsVo6pfw8tm95FvqYE1dF9yWncxTB tIj5l+ka7nbG3Ny2ywHjZzOHuUnE4NVVsozwId1ZjHd5y1DRBQg6sWQ7UFcTfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cGGKW6Y8WzCVp; Tue, 02 Sep 2025 06:38:39 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: dfafdbdfc3e9 - main - stand: Use calloc instead of malloc for initialization of filesystem devsw From: Zhenlei Huang In-Reply-To: <202509012201.581M18tv010659@gitrepo.freebsd.org> Date: Tue, 2 Sep 2025 14:38:35 +0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202509012201.581M18tv010659@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Sep 2, 2025, at 6:01 AM, Warner Losh wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Ddfafdbdfc3e9db8b878283bcbef35f5d= 8d37dae8 >=20 > commit dfafdbdfc3e9db8b878283bcbef35f5d8d37dae8 > Author: null =20 Hi Warner, The Author is missing. Probably by mistake of Phabricator ? Best regards, Zhenlei > AuthorDate: 2025-09-01 21:57:06 +0000 > Commit: Warner Losh > CommitDate: 2025-09-01 21:57:14 +0000 >=20 > stand: Use calloc instead of malloc for initialization of = filesystem devsw >=20 > This change is required for https://reviews.freebsd.org/D49355, so = that > we can check if d_dev is uninitialized by checking if it's NULL. >=20 > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D49705 > --- > stand/common/disk.c | 2 +- > stand/kboot/kboot/hostdisk.c | 2 +- > stand/libofw/devicename.c | 2 +- > stand/libsa/dev.c | 2 +- > stand/libsa/zfs/zfs.c | 2 +- > stand/uboot/devicename.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/stand/common/disk.c b/stand/common/disk.c > index c1650f0fa1ec..1baf91efaa49 100644 > --- a/stand/common/disk.c > +++ b/stand/common/disk.c > @@ -468,7 +468,7 @@ disk_parsedev(struct devdesc **idev, const char = *devspec, const char **path) >=20 > if (*cp !=3D '\0' && *cp !=3D ':') > return (EINVAL); > - dev =3D malloc(sizeof(*dev)); > + dev =3D calloc(sizeof(*dev), 1); > if (dev =3D=3D NULL) > return (ENOMEM); > dev->dd.d_unit =3D unit; > diff --git a/stand/kboot/kboot/hostdisk.c = b/stand/kboot/kboot/hostdisk.c > index a9117d4c1c9d..fc98bf534519 100644 > --- a/stand/kboot/kboot/hostdisk.c > +++ b/stand/kboot/kboot/hostdisk.c > @@ -465,7 +465,7 @@ hostdisk_parsedev(struct devdesc **idev, const = char *devspec, const char **path) > return (EINVAL); > } > free(fn); > - dev =3D malloc(sizeof(*dev)); > + dev =3D calloc(sizeof(*dev), 1); > if (dev =3D=3D NULL) > return (ENOMEM); > dev->d_unit =3D 0; > diff --git a/stand/libofw/devicename.c b/stand/libofw/devicename.c > index f6419632c6bc..46a9717fdda5 100644 > --- a/stand/libofw/devicename.c > +++ b/stand/libofw/devicename.c > @@ -98,7 +98,7 @@ ofw_common_parsedev(struct devdesc **dev, const char = *devspec, const char **path >=20 > if (ofw_path_to_handle(devspec, ofwtype, &rem_path) =3D=3D -1) > return (ENOENT); > - idev =3D malloc(sizeof(struct ofw_devdesc)); > + idev =3D calloc(sizeof(struct ofw_devdesc), 1); > if (idev =3D=3D NULL) { > printf("ofw_parsedev: malloc failed\n"); > return (ENOMEM); > diff --git a/stand/libsa/dev.c b/stand/libsa/dev.c > index 1edc843d508c..4f6932e96c48 100644 > --- a/stand/libsa/dev.c > +++ b/stand/libsa/dev.c > @@ -72,7 +72,7 @@ default_parsedev(struct devdesc **dev, const char = *devspec, > int unit, err; > char *cp; >=20 > - idev =3D malloc(sizeof(struct devdesc)); > + idev =3D calloc(sizeof(struct devdesc), 1); > if (idev =3D=3D NULL) > return (ENOMEM); >=20 > diff --git a/stand/libsa/zfs/zfs.c b/stand/libsa/zfs/zfs.c > index 70a102f6425d..2f7c1caaa4b5 100644 > --- a/stand/libsa/zfs/zfs.c > +++ b/stand/libsa/zfs/zfs.c > @@ -1643,7 +1643,7 @@ zfs_parsedev(struct devdesc **idev, const char = *devspec, const char **path) > spa =3D spa_find_by_name(poolname); > if (!spa) > return (ENXIO); > - dev =3D malloc(sizeof(*dev)); > + dev =3D calloc(sizeof(*dev), 1); > if (dev =3D=3D NULL) > return (ENOMEM); > dev->pool_guid =3D spa->spa_guid; > diff --git a/stand/uboot/devicename.c b/stand/uboot/devicename.c > index 4ee9c7fd72c4..23670d7593a2 100644 > --- a/stand/uboot/devicename.c > +++ b/stand/uboot/devicename.c > @@ -102,7 +102,7 @@ uboot_parsedev(struct uboot_devdesc **dev, const = char *devspec, > } > if (dv =3D=3D NULL) > return(ENOENT); > - idev =3D malloc(sizeof(struct uboot_devdesc)); > + idev =3D calloc(sizeof(struct uboot_devdesc), 1); > err =3D 0; > np =3D (devspec + strlen(dv->dv_name)); >=20