From owner-svn-src-projects@FreeBSD.ORG Thu Dec 23 09:41:29 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5FA1106566B for ; Thu, 23 Dec 2010 09:41:29 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 32F7F8FC0C for ; Thu, 23 Dec 2010 09:41:28 +0000 (UTC) Received: by fxm16 with SMTP id 16so6542062fxm.13 for ; Thu, 23 Dec 2010 01:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=CSKCL9aDoyGK+IIOIlrGbFegwbLel15k6mii2gRnUHU=; b=Yt12kxbsKTRo7pg+d9mJXugvNhdFc57+TIkB0SBNO3OGUnMwlucF9P5DFrlfjSRFWp CKLIxL3m0jUdVQTzmPaDb5SvyYIJpNWXf7BwT5QFB8/3kezYfu8hMAcfPeFyc0a7MGOq uYIg2sBUkW9PJdeKLBvXAQpr4hREVmf+Bs3b4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=iJ94LW3Cr8F2KhvZ4jJwuJ/kDToN/ew0qm4djtu33mrFmT0P08HAy9TC2P3zejTQ2A 1nV7v51qtO/QCKV7tnHkHlFtsqm83dHQa4q+z7jW7bDYEkZTPkeI2QE2CF21+oNLEEEX kqGM7dcyvCwNlblfhKyUZvPaAAJzOry+6ItB8= Received: by 10.223.96.202 with SMTP id i10mr7657377fan.50.1293095607497; Thu, 23 Dec 2010 01:13:27 -0800 (PST) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id y3sm1943234fai.14.2010.12.23.01.13.24 (version=SSLv3 cipher=RC4-MD5); Thu, 23 Dec 2010 01:13:25 -0800 (PST) Sender: Alexander Motin Message-ID: <4D13129D.3080606@FreeBSD.org> Date: Thu, 23 Dec 2010 11:13:01 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201012220902.oBM92MpZ098772@svn.freebsd.org> <20101223090812.GA43446@garage.freebsd.pl> In-Reply-To: <20101223090812.GA43446@garage.freebsd.pl> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216649 - projects/graid/head/sys/geom/raid X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2010 09:41:29 -0000 Pawel Jakub Dawidek wrote: > On Wed, Dec 22, 2010 at 09:02:22AM +0000, Alexander Motin wrote: >> Author: mav >> Date: Wed Dec 22 09:02:22 2010 >> New Revision: 216649 >> URL: http://svn.freebsd.org/changeset/base/216649 >> >> Log: >> Implement basic metadata generation check. To be sure that used metadata is >> up to date - delay volumes creation until we have all disks or timeout >> expires. This probably obsolete same functionality done at volumes level. > [...] >> +static struct intel_raid_conf * >> +intel_meta_copy(struct intel_raid_conf *meta) >> +{ >> + struct intel_raid_conf *nmeta; >> + >> + nmeta = malloc(meta->config_size, M_MD_INTEL, M_WAITOK | M_ZERO); >> + memcpy(nmeta, meta, meta->config_size); >> + return (nmeta); >> +} > > The M_ZERO flag seems to be redundant, as you fill the entire buffer in > the next line. Indeed. Thanks. But I am sure it is not the biggest of my problems. :) -- Alexander Motin