Date: Thu, 24 May 2007 07:55:06 -0500 From: Stephen Montgomery-Smith <stephen@math.missouri.edu> To: pav@freebsd.org Cc: gnome@freebsd.org, freebsd-ports@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: More speed increases for make-ing ports Message-ID: <46558B2A.5020806@math.missouri.edu> In-Reply-To: <1180010691.66903.28.camel@pav.hide.vol.cz> References: <465291FB.4010901@math.missouri.edu> <20070522071941.GB59910@xor.obsecurity.org> <4652FFB4.8060107@math.missouri.edu> <1179846295.52353.27.camel@pav.hide.vol.cz> <4653349D.7080608@math.missouri.edu> <46533D66.1070305@math.missouri.edu> <1179868612.83498.6.camel@ikaros.oook.cz> <1179869940.83498.9.camel@ikaros.oook.cz> <20070522165525.S52261@math.missouri.edu> <1179871899.83498.10.camel@ikaros.oook.cz> <20070522172627.A52261@math.missouri.edu> <465398E0.40404@math.missouri.edu> <1179907804.60308.1.camel@pav.hide.vol.cz> <4654E491.5000700@math.missouri.edu> <1179995317.66903.17.camel@pav.hide.vol.cz> <46558678.3020704@math.missouri.edu> <1180010691.66903.28.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------060800010701060502060207 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8bit Pav Lucistnik wrote: > Stephen Montgomery-Smith píše v čt 24. 05. 2007 v 07:35 -0500: >> Pav Lucistnik wrote: >>> Stephen Montgomery-Smith píše v st 23. 05. 2007 v 20:04 -0500: >>> >>>> I'm getting kind of uncomfortable with the patch. I looked some more >>>> in >>>> bsd.gnome.mk and it seems to me that the suggested patch is really >>>> equivalent to the patch enclosed here. >>>> >>>> Why did the writer of bsd.gnome.mk have the rather complicated >>>> construction which I am proposing to replace? >>> I don't know, we'd have to ask Joe Marcus. Here is the revision in >>> question: >>> >>> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=1.22;r2=1.23 >>> >>> You're basically reverting that revision. Perhaps our make(1) wasn't >>> smart enough those four years ago, I don't know. >> I'm not really reverting that revision. As it was prior to that >> revision, I can see it not working under many circumstances. Namely, if >> ${component} appears more than once in ${_USE_GNOME} - something that >> will happen frequently - the test will not work. >> >> My revision seems the obvious way to do it to me, but I can see that if >> someone was working with what Joe was working with, that one could be >> lead to think up his revision. I know that I myself have missed the >> obvious in many circumstance. > > Please send me the patch again, as an attachment, I'll give it some > workout :) > Here it is. --------------060800010701060502060207 Content-Type: text/plain; name="eee" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="eee" --- bsd.gnome.mk-orig Mon Mar 19 23:13:36 2007 +++ bsd.gnome.mk Wed May 23 19:25:19 2007 @@ -689,9 +689,9 @@ # Then traverse through all components, check which of them # exist in ${_USE_GNOME} and set variables accordingly +.ifdef _USE_GNOME . for component in ${_USE_GNOME_ALL} -_COMP_TEST= ${_USE_GNOME:M${component}} -. if ${_COMP_TEST:S/${component}//}!=${_COMP_TEST:S/ / /g} +. if ${_USE_GNOME:M${component}}!="" PATCH_DEPENDS+= ${${component}_PATCH_DEPENDS} FETCH_DEPENDS+= ${${component}_FETCH_DEPENDS} EXTRACT_DEPENDS+=${${component}_EXTRACT_DEPENDS} @@ -725,6 +725,7 @@ . endif . endfor +.endif .endif .if defined(GNOME_PRE_PATCH) --------------060800010701060502060207--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46558B2A.5020806>