From owner-cvs-all@FreeBSD.ORG Wed Feb 15 08:46:58 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 022D4106566B; Wed, 15 Feb 2012 08:46:58 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C67318FC0C; Wed, 15 Feb 2012 08:46:57 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id q1F8kvYt051292; Wed, 15 Feb 2012 08:46:57 GMT (envelope-from dougb@repoman.freebsd.org) Received: (from dougb@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id q1F8kvCi051291; Wed, 15 Feb 2012 08:46:57 GMT (envelope-from dougb) Message-Id: <201202150846.q1F8kvCi051291@repoman.freebsd.org> From: Doug Barton Date: Wed, 15 Feb 2012 08:46:57 +0000 (UTC) To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: ports/sysutils/smartmontools Makefile pkg-plist ports/sysutils/smartmontools/files smartd.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2012 08:46:58 -0000 dougb 2012-02-15 08:46:57 UTC FreeBSD ports repository Modified files: sysutils/smartmontools Makefile pkg-plist sysutils/smartmontools/files smartd.in Log: This change has various simplifications/improvements for the port. Most importantly, it's currently installing the rc.d script from the source, rather than the fixed one in files/. 1. Remove 6.x compatibility hack 2. Use the PORTDOCS macro 3. Actually install the rc.d script in files/ 4. Simplify pkg-plist 5. For the rc.d script: a. Move it to the standard location, after LOGIN b. Add KEYWORD nojail per the script in the distfiles c. Put the standard arguments in their usual order/formats d. Simplify the assignments of pidfile and required_files e. Use command_args for required arguments, don't abuse _flags f. The test for -p in smartd_flags should be a start_precmd, we frown on running any code unconditionally. Also, improve this check if -p is first. g. Bring the reload and report options from the distfile version, and simplify them. PR: ports/165167 Submitted by: me Approved by: Alex Samorukov (maintainer) Revision Changes Path 1.57 +4 -4 ports/sysutils/smartmontools/Makefile 1.4 +51 -25 ports/sysutils/smartmontools/files/smartd.in 1.8 +1 -19 ports/sysutils/smartmontools/pkg-plist