From owner-freebsd-ports@freebsd.org Mon Mar 22 18:42:25 2021 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4197D5B82F2 for ; Mon, 22 Mar 2021 18:42:25 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F43Jd13xtz4cM5 for ; Mon, 22 Mar 2021 18:42:24 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf36.google.com with SMTP id 30so9162005qva.9 for ; Mon, 22 Mar 2021 11:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7hMSFjDipGy8w4KUSth9zEYFKsBOGVjHvhrWHep754U=; b=Zqy7hTBLZ+FEPMl0VuQNQlQwjt/dIZMR08gpDgv7Nf9NjBz0xZRHKBIALG9CZTvGSt gWdruHKA+SHzrLFMmu8bIs8tUeHqJgmoPpHkAEaKA1rOERKpUiGkx9mtY3Yg+JrDHDAD 9yeRGAlYdxFxomQw/+SVa18c+Wd0wB2BlYd1UDvuJ84nxvhlbnMJJe2wvnOm9Gf4Ndeq EPUx3TnK+ML5p38KQNTuPh5Iou3brtZvbGygyXYZAblHAQga0YCGUsrklXyti7HMCnvp LQ5AAuuLTWIrLNKNLp9F2b35qLZDSO2PJYy5AaAdmVMCYTwij/LIRyfibDh9P54zLLb0 S30Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7hMSFjDipGy8w4KUSth9zEYFKsBOGVjHvhrWHep754U=; b=WoeaWco7cJRdmD62FSyBpfVWpeVqfT6XwIkIVePzLhS3vso6cwiykq95VFLWY8t11v vYCa37jfSDl0ALG86QeT7TukQE/IJ5aJJCMnN9wf8nDZLZhsnDURSf2vYyE+VU7nS7Tl VLawZ2cvJHP/TVL20/OwJ1nEYB50J1jSDgAzYLbOl9nKNMSFK5+eiAM3YMa0MohSaIW6 R8DCJEgCcUNSpTKwunx2oKDCQxn17w3jFn8ojse+gVGzBfa+OmbpI/HdIgaSnJrIN6fq 3qfQfWiuZuNkuweSrJx+4OAPAm5fTrsHZz9qp1Zg03QTNHNFJW/v6ji7N3snvz+E4nZq CafQ== X-Gm-Message-State: AOAM53376NzWuBP2WUZBbHWdh7ZYekif9b+e6kMA8z5bbg+CuD9aR8yJ WMMGgByDjd/KkXHFIOL/z/K+aTIt+a6wRQ== X-Google-Smtp-Source: ABdhPJzXdnE5WJz6DUDU0Rl7KYKoeZ7acqzsimB5zp0kGRrGrYJnJMKsnaUV8rg+arnyxW0Ij4VJ6Q== X-Received: by 2002:ad4:55ef:: with SMTP id bu15mr1046189qvb.46.1616438543563; Mon, 22 Mar 2021 11:42:23 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id z5sm9715840qtc.42.2021.03.22.11.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 11:42:22 -0700 (PDT) Date: Mon, 22 Mar 2021 14:42:22 -0400 From: Shawn Webb To: Dimitry Andric Cc: freebsd-ports@freebsd.org Subject: Re: TCL and Unicode Message-ID: <20210322184222.xhcomcjej32hmbi6@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <20210322134003.hhdmq6ljxun4tsyn@mutt-hbsd> <829C6E3C-12B3-44FC-8B18-D3F0ACA87B57@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sgo4zfijb5r2yg5g" Content-Disposition: inline In-Reply-To: <829C6E3C-12B3-44FC-8B18-D3F0ACA87B57@FreeBSD.org> X-Rspamd-Queue-Id: 4F43Jd13xtz4cM5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 18:42:25 -0000 --sgo4zfijb5r2yg5g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 22, 2021 at 06:32:29PM +0100, Dimitry Andric wrote: > On 22 Mar 2021, at 14:40, Shawn Webb wrote: > >=20 > > I'm tracking down a regression in ports regarding TCL and unicode. The > > primary victim of the problem is databases/sqlite3. Note that I use > > freebsd-ports on github as my upstream, so I'll be using git commit > > hashes from that repo. > >=20 > > The sqlite3 build failure can be seen at [1]. > >=20 > > If I revert commit 787aad81fc79d441fb0c9a750e6e33b6c0ea7ac6, sqlite3 > > builds fine. I noticed a few key changes from that commit: > >=20 > > The build of sqlite3 depends on TCL: instead of using the distfile > > that has the autoconf artifacts pre-generated, the distfile without > > the autoconf artifacts is used (changing from > > sqlite-autoconf-3340100.tar.gz to sqlite-src-3340100.zip). This > > means that the TCL-based autoconf artifacts must be generated > > locally. At least, partially. It seems that the only part of the > > build that depends on TCL is the sqlite3_analyzer. > >=20 > > Admittedly, this change is somewhat confusing to me. I'm having > > somewhat of a hard time knowing whether it's TCL or sqlite3 itself > > as the main culprit. > >=20 > > Any guidance is appreciated. > >=20 > > [1]: http://ci-08.md.hardenedbsd.org/data/hardenedbsd-current_amd64-loc= al/2021-03-21_13h53m43s/logs/errors/sqlite3-3.34.1,1.log >=20 > Hi Shawn, >=20 > It builds fine for me locally on 14.0-CURRENT (as of ~2 days ago), and > indeed the sqlite3.c file is now dynamically generated by tcl. >=20 > In your CI failure case, it looks like something is inserting blobs of > zero bytes into the resulting file, though? So either the file system > is going bad, or tcl is outputting nonsense, for some reason. At least, > I think you'll have to do some investigations in that direction... Looks like compiling lang/tcl86 with the following CFLAGS causes tcl to output invalid unicode for some reason: -ftrivial-auto-var-init=3Dzero -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang Thanks for the hint! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --sgo4zfijb5r2yg5g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBY5QsACgkQ/y5nonf4 4fqAew//Yln9E1cp7j5JRCZKFi3oAjCV6uEsFaqv38XpwGPHC34B/pe5TwfC9eg9 pqR1ojTGzoDRpwueBcT6ZTrWPwx6hZbA8EtUMhQHHSSoUJPfTzAAfyqc2dpWzeb1 l/l8TD72x+Ae3O4mfW6iyWSXGasVi1E45XOdRiarPiugeO6GPTc53su/b9Uysm18 Z4wVUCI87gilN93hjBn2+41+bZAVUw4nOlcP6nxaug6Rd+8KQlTkVYgUdQSsFgSj ldbkaSJVUCE05q9LdBdWxBbI9lJsOrtbxYGFlVuq9UfjvpPJH8mVA47DA+vD6gNI rUEOtRlwZzoG3RofYLUqkdS82BiuJa2g1Du150uxg+CnKoj0/0lKDdIYv+aKdR1R ssfM3nCOeoKPcJKeSIP59F7xR5DUvduoEh8MvaUiQmI/+601aP6BUgPriynJmtHr 5auJgXF0iYW0x5w6N0m6Zr2kLLED2e/KhtsRBK3MiHkMIlvvT5h/jwTd2/5DLalp +2uZTHmt+Njh4XUpqsGgoXEePsvvpcMd6PdhTcXD7BzsAM7r+fR/c9U26Re3+MYP 8iEL3cHgpbSZ3jQ2aUSBIKpb4FLVTG9qru4kRr0b9BViTxpbvlLb6A2FJ0vFOb0b XrbU2e5HbImvLGceUw5aLe8Jaiaum2m7k/a/FVrldUWyj2Vu8O0= =PmJU -----END PGP SIGNATURE----- --sgo4zfijb5r2yg5g--