From owner-svn-src-head@freebsd.org Sun Aug 25 20:26:44 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 73D63C1257; Sun, 25 Aug 2019 20:26:44 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46GmrM12krz4Pth; Sun, 25 Aug 2019 20:26:42 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x232.google.com with SMTP id x3so13212736lji.5; Sun, 25 Aug 2019 13:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3yy8EnM/zZwuj7tJGSTuZ+IsF8YcWsrwqUNdoux67sc=; b=lxZU+rROylddv7U/7qKhw8S7cckgKPSVdC85g6r73PIi+Hg4lWxkrSz265TbPiJJFL oll5CScYPzC4tKYsohpDO36mPKvj2iWMgwRbdl0Fzr3MygAaxi3+D5DNJg5CbjvxqUAM ZOf+SWKdUHL1If8uEOlzza35oR0ZSMQ5wG4c/YoRdll1tN1KpGsweLDDznOMirtHcLci qriNWzh07qNVVvstUBjzEV3Rj8qlcCgXLqOzABKbwG/bOh2pPQ9/MEZ/4m135PNKqg1D v15jPopY3cCSJGBRnPAbsioiXkFNjF0/IUmLqew0oa1P1GsC/ravyUPW4VRVyjbr3hTh Pecg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3yy8EnM/zZwuj7tJGSTuZ+IsF8YcWsrwqUNdoux67sc=; b=ERxSv05h6gl3T0IJkwY+UhJYAm+jvRM0Jzstc3FsYui/8KirBozb7bxd4LlGuUQk1N d5I1TGpgk3u+lWYKtbBeistIooCMw49Sgb6zhqLW0wvw14YKI7sPwFIs8EDwgJDMWeLd XegE5Oxaq8+WNkPX8kGD9RX/uNYnSJbZn1yewDRa/6lsYtlwHGn5WI4Yqpq/5FN6IYZM 1AIlSFSgV1nXmTAtBjfsflK50NVsZkI9uLHt+Tp8WagxRiy2hR3SaFJJ8JdcPcPLXdFJ 35c4vqlDb2Pe4KxjNYUfC9LL5hxxtrDSFZg4d4uoqzbk8yFXk6arhxSnSOKqc34CiulC c7VQ== X-Gm-Message-State: APjAAAWYUMMRZPa6ULJtTzoj2g93Rchf6Az3FCFY7iF2PxoZxU+FJAD3 nkg+7qx64W/smyvruLLAu8K+MBK7z1nOjj9jUio= X-Google-Smtp-Source: APXvYqxDE3/edXt0jWjj1QUOFE09RZtQl9I8om2NvmfT2F6XG4uUv3uW7A4J5PlMwJeIlWeXGSCftZ6nZR7m0s8jB9M= X-Received: by 2002:a2e:864c:: with SMTP id i12mr8472014ljj.88.1566764800932; Sun, 25 Aug 2019 13:26:40 -0700 (PDT) MIME-Version: 1.0 References: <201908231522.x7NFMLuJ068037@repo.freebsd.org> <20190826.042056.1329861772202588895.hrs@allbsd.org> <20190826.050922.1810654532466043358.hrs@allbsd.org> In-Reply-To: <20190826.050922.1810654532466043358.hrs@allbsd.org> From: alan somers Date: Sun, 25 Aug 2019 14:26:28 -0600 Message-ID: Subject: Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests To: Hiroki Sato Cc: Alan Somers , Jan Sucan , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 46GmrM12krz4Pth X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=lxZU+rRO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 2a00:1450:4864:20::232 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(0.00)[ip: (-8.98), ipnet: 2a00:1450::/32(-3.00), asn: 15169(-2.33), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Aug 2019 20:26:44 -0000 On Sun, Aug 25, 2019, 2:11 PM Hiroki Sato wrote: > Alan Somers wrote > in : > > as> On Sun, Aug 25, 2019 at 1:22 PM Hiroki Sato wrote: > as> > > as> > Hi, > as> > > as> > Alan Somers wrote > as> > in <201908231522.x7NFMLuJ068037@repo.freebsd.org>: > as> > > as> > as> Author: asomers > as> > as> Date: Fri Aug 23 15:22:20 2019 > as> > as> New Revision: 351423 > as> > as> URL: https://svnweb.freebsd.org/changeset/base/351423 > as> > as> > as> > as> Log: > as> > as> ping6: Rename options for better consistency with ping > as> > as> > as> > as> Now equivalent options have the same flags, and nonequivalent > options have > as> > as> different flags. This is a prelude to merging the two > commands. > as> > as> > as> > as> Submitted by: J=C3=A1n Su=C4=8Dan > as> > as> MFC: Never > as> > as> Sponsored by: Google LLC (Google Summer of Code 2019) > as> > as> Differential Revision: https://reviews.freebsd.org/D21345 > as> > > as> > I have an objection on renaming the existing option flags in > ping6(8) > as> > for compatibility with ping(8). > as> > > as> > Is it sufficient to add INET6 support to ping(8) with consistent > as> > flags and keep CLI of ping6(8) backward compatible? People have > used > as> > ping6(8) for >15 years, so it is too late to rename the flags. I = do > as> > not think the renaming is useful if "ping -6 localhost" or "ping > ::1" > as> > works. > as> > > as> > -- Hiroki > as> > as> If ping works with inet6, then why would we want to keep a separate > as> tool around? If it's just for the sake of people who don't want to o= r > as> can't update scripts, would a version in ports suffice? > > Because removing (or renaming) it causes a POLA violation. Do we > really have a strong, unavoidable reason to force people to rewrite > their script now? This is still a fairly essential and actively used > tool, not like rcp or rlogin. Although deprecating ping6(8) and > removing it from the base system in the future release at some point > may work, changing the existing interface will simply confuse people > who have used IPv6 for a long time. > > In my understanding, the purpose to integrate ping(8) and ping6(8) > into a single utility is to provide a consistent CLI and reduce > duplicate code, not to break compatibility. > > -- Hiroki > Those goals are incompatible. We can't provide a consistent CLI without breaking compatibility because ping and ping6 have conflicting options. And we can't keep ping6 around while also removing duplicate code because that would be, well, duplicate code. When would be a better time than a major version bump to make a change like this? The lack of a ping6 command in freebsd 13 should serve as a pretty obvious reminder that scripts will need updating. I think that putting a version of ping6 in ports should be a sufficient crutch for those who need it, don't you? >