From owner-svn-src-all@freebsd.org Thu Dec 1 16:58:18 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE838C619F0; Thu, 1 Dec 2016 16:58:18 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id A9D171235; Thu, 1 Dec 2016 16:58:18 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from sweettea.beer.town (unknown [76.164.8.130]) by smtp.vangyzen.net (Postfix) with ESMTPSA id CFE0C5648E; Thu, 1 Dec 2016 10:58:17 -0600 (CST) Subject: Re: svn commit: r309331 - head/usr.bin/locale To: Bruce Evans References: <201611301834.uAUIYfQs075427@repo.freebsd.org> <20161201082459.T1285@besplex.bde.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Eric van Gyzen Message-ID: Date: Thu, 1 Dec 2016 10:58:13 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161201082459.T1285@besplex.bde.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 16:58:18 -0000 On 11/30/2016 18:19, Bruce Evans wrote: > On Wed, 30 Nov 2016, Eric van Gyzen wrote: > >> Log: >> Include limits.h for CHAR_MAX >> >> This was needed on stable/10. Apparently, sys/param.h supplies CHAR_MAX >> on head. Include limits.h anyway, for consistency, and because C >> says so. > > sys/param.actually supplies CHAR_MAX (undocumented namespace pollution) in > all versions of FreeBSD. Yes, I was too terse. I meant, locale.c gets CHAR_MAX from sys/param.h on head (and 11), but does not include sys/param.h on 10. > Untested fixes and cleanups: > > Y diff -u2 locale.c~ locale.c Thanks. Committed. Eric