From owner-freebsd-net@FreeBSD.ORG Mon Apr 6 16:36:22 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 182EC25D; Mon, 6 Apr 2015 16:36:22 +0000 (UTC) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EFCF6F7C; Mon, 6 Apr 2015 16:36:21 +0000 (UTC) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id ADF6211E5F; Mon, 6 Apr 2015 09:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1428338174; x=1428352574; bh=y34+aXPQ10nwx8a4FfjLnokPJwLRao3cJWVgBA35F7U=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=ULUvLMIKFYe3uyV3G20iWZN0QdINFxcgv+s9HACNyIohAXgjzEZBM52UjesMUk2Ts RgBGZRmfPkeGwXpmalgR1zJfmI+TzB1f+dyvi5brPkmUwM7p/tW4kIQ02LUFK5RFZS hAfDdIMSsIIPRqm5cxzcmWUBRy6B7eonRxrSoT8o= Message-ID: <5522B5FD.5040308@delphij.net> Date: Mon, 06 Apr 2015 09:36:13 -0700 From: Xin Li Reply-To: d@delphij.net Organization: The FreeBSD Project MIME-Version: 1.0 To: hiren panchasara , freebsd-net@freebsd.org Subject: Re: Bring "netstat -R" to stable10 References: <20150402205307.GA72165@strugglingcoder.info> <20150406162015.GB96049@strugglingcoder.info> In-Reply-To: <20150406162015.GB96049@strugglingcoder.info> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: re X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2015 16:36:22 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 04/06/15 09:20, hiren panchasara wrote: > On 04/02/15 at 01:53P, hiren panchasara wrote: >> I want to use netstat -R on stable10 and following 2 commits are >> needed to be MFC'd for that: >> https://svnweb.freebsd.org/base?view=revision&revision=266418 >> https://svnweb.freebsd.org/base?view=revision&revision=266448 >> >> r266418 adds a field to 'struct inpcb' but it uses a spare field >> so I _think_ it's MFCable and doesn't break KBI/KPI? >> >> Can someone please comment if that's not the case? > > I'll go commit this today. I think you should have asked re@ or this may get otherwise unnoticed... I was kinda surprised with the fact that the spare fields are defined as 'uint' and not something like 'u_int32_t' because the former is less defined. We should probably use u_int32_t instead for the spare fields to avoid the ambiguity. However, because all platforms that FreeBSD currently supports have 32-bit int (doing a quick grep of __UINT_MAX), I think the change does not break KBI. The added field does not break KPI. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.2 (FreeBSD) iQIcBAEBCgAGBQJVIrX9AAoJEJW2GBstM+nsqPIQAJbPIm/+CW8M7GYIsi+7uZhB lmre7YxpRQrYZhIEcpbu7M06v/qCzAqnrIxbddOtvOjSvc606yW5fgQlns30IoD0 BzOpu0Q8tTwYMRq2ccQ02hQoODvMkFPNloTqxe5XXs7Gc+QqVQxehmKZhEIpTSDY JzMWmJlfthAl5BUx5c9SbrgYCd9XkLYpqGeRD7KbveU5dlVXB/wEsftRH9d7TrRb Q+Ug6y6nsb0XGF9ayUcsK68EbXSgbxvA3LVummeiRuFuFUcCQ1JqCAIQo13yWckQ bGk8Bw5a5kXUrRzH/TkGHKqUVxxl7hRunUu4NIHmI8wbjS/qcchFiWgC9B2BO4WX ri/2UHYJVf4Ll3gefD6MdG07Y46DZCKtEkcmynxW8jtC+eomi7uQundGr7jKshCt mnT9c/s0lIBwW639QQNEkJOI3/ZZJuU7IjSf7jgbnO0+MD6GS7O4qrxp/yfQxXjJ lSY6qWuxF4eAzv0DUWYpHHG0BT1payu/ZnFgunPyj5ym1Kadm2nASMJt3nCOmlow oapz7K1L5nGAPnQf5JHPO2mHIowLoBJbTYU/KtAZ8HSiKBFBG2EcNd0j9Dd11TD8 uTGNvNVo3CFkyUIU/bRDWbFIP/BXk4BRUepgglDVk+eij24bGX4gCyfFgvWQ+/sw QrAa+rUvIMhaLJL8WuyA =Btjt -----END PGP SIGNATURE-----