From owner-freebsd-net@FreeBSD.ORG Tue Nov 23 09:01:12 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3429E106566B for ; Tue, 23 Nov 2010 09:01:12 +0000 (UTC) (envelope-from fabien.thomas@netasq.com) Received: from work.netasq.com (mars.netasq.com [91.212.116.3]) by mx1.freebsd.org (Postfix) with ESMTP id 8FFEA8FC15 for ; Tue, 23 Nov 2010 09:01:11 +0000 (UTC) Received: from [10.20.1.1] (unknown [10.2.27.254]) by work.netasq.com (Postfix) with ESMTPSA id 18BA9740008; Tue, 23 Nov 2010 09:40:18 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: multipart/mixed; boundary=Apple-Mail-18-809381120 From: Fabien Thomas In-Reply-To: <4CEB567C.9000906@rdtc.ru> Date: Tue, 23 Nov 2010 09:41:49 +0100 Message-Id: References: <20101117070422.GA45678@cabstand.com> <4CE3D097.7030204@grosbein.pp.ru> <4CEB567C.9000906@rdtc.ru> To: Jack Vogel X-Mailer: Apple Mail (2.1082) Cc: FreeBSD Net , Vlad Galu , Eugene Grosbein Subject: Re: request for MFC of em/igb drivers X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 09:01:12 -0000 --Apple-Mail-18-809381120 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii That fix on ixgbe would also be great to commit on ixgbe before release. This fix a crash on high packet load with bpf (mbuf freed behind bpf = analysis). Fabien --Apple-Mail-18-809381120 Content-Disposition: attachment; filename=patch-ixgbe-bpfcrash Content-Type: application/octet-stream; name="patch-ixgbe-bpfcrash" Content-Transfer-Encoding: 7bit diff --git a/sys/dev/ixgbe/ixgbe.c b/sys/dev/ixgbe/ixgbe.c index 174c08d..073818e 100644 --- a/sys/dev/ixgbe/ixgbe.c +++ b/sys/dev/ixgbe/ixgbe.c @@ -1591,6 +1702,10 @@ ixgbe_xmit(struct tx_ring *txr, struct mbuf **m_headp) m_head = *m_headp; + /* Do a clean if descriptors are low */ + if (txr->tx_avail <= IXGBE_TX_CLEANUP_THRESHOLD) + ixgbe_txeof(txr); + /* Basic descriptor defines */ cmd_type_len = (IXGBE_ADVTXD_DTYP_DATA | IXGBE_ADVTXD_DCMD_IFCS | IXGBE_ADVTXD_DCMD_DEXT); @@ -1740,10 +1855,6 @@ ixgbe_xmit(struct tx_ring *txr, struct mbuf **m_headp) ++txr->total_packets; IXGBE_WRITE_REG(&adapter->hw, IXGBE_TDT(txr->me), i); - /* Do a clean if descriptors are low */ - if (txr->tx_avail <= IXGBE_TX_CLEANUP_THRESHOLD) - ixgbe_txeof(txr); - return (0); xmit_fail: --Apple-Mail-18-809381120 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > > On 17.11.2010 23:39, Jack Vogel wrote: >> Yes, everyone, I plan on updating all the drivers, there has been no >> activity >> because I've tracking down a couple bugs that are tough, involving days >> of testing to reproduce. I know we're getting close and I appreciate any >> reports like this before. >> >> Stay tuned.... >> >> Jack > > Thanks for response. Do you play to MFC fixes before 8.2-RELEASE? > We are in PRERELEASE state already :-) > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" --Apple-Mail-18-809381120--