From nobody Sun Mar 26 19:21:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pl5RK4XfRz42Cns; Sun, 26 Mar 2023 19:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pl5RK44T1z40Jn; Sun, 26 Mar 2023 19:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679858509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8egDH4yD4L8tK1m4nZUiEwKwG7n1/wkZXsmO8gJzf4k=; b=IruOq41z/mfzItk/ArMpo2vB2wmZ9Y6fybY4kbKkwdWfnT64g30OCpepfXn4yHil3RzYJ1 1ebOs4ke0eWSGSdpLzKYDsBxjSVvqkJVi0Us0kFjgvO1wTJ0C+/4J95q3djDHtDGjkypqE tRUhMnIwj5Z9vn1ZdhUGwzRtV9Jg9YF+NsSwGSzmz+PEfryPbiNDv2IpTAYFZKy3XjiQGD metKe1bFAYwbNWumhnutzGxkvPZuVcXleqn/uRyrbtSd33tbzLq5YK2lfThTLt/S7vskqZ 3h33+xUw+TDtLZ8DWQJZksUz5GzfQVhRYgG1icjMiZTyLJ4NHaZjBMpD2vIAbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679858509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8egDH4yD4L8tK1m4nZUiEwKwG7n1/wkZXsmO8gJzf4k=; b=BrlQfu/UdPm9yAO3Kom/fCBo3DOpMhvzTEN5sN1kY9TAifuVZXNdSU3T0e6keyiafK7kXA 7lRAH4RV/gWG4UtVzGnKFWn9hce36HvN8FznXmf06/SQCMZWvYIXSNtwf3nxnwiXy00O6k ZxhXdYYqmmNpBHiyzhfDi2iiy7eM6gfaIAYbiD+GTHL1Hl4gTtbGbf0ToWRGa/Qq53i9oB L8X9o7lBUaDJsLOx2TcXCWsX1hLvQMCwfs1Mt1Fpb+cyRQodevJn6Wx4nHAg2J8Rd1DDkT 5byPNrhsn0/I+f2/cly1+7dOZY3LNyX4hezS25vKH33KsFJfYIjcENgS1RsYRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679858509; a=rsa-sha256; cv=none; b=djHtMMg6GZXrASPp7O+uzdFg7OnA2Pukb3fDBNd9AS+1mgTpOTAIUM67OcPQx/BQgUF6ih t7GIvK6Yml2amgGoxEornuwazRaMttHo0mFJMFVnPSt/90aLEFCN6SatVQ8gUFdUES0BC5 JTYLvu+xecY5uZTdqMehH1qXbouxRsdksW+eYr/r2Ll4Ss2aTioMbwnAWC0cCzQZ9D5205 cRo4VO/mtLhKpSHluC0q35GsYHxbwcO/GKgcT3Br+hoSqKuCMTlEaZ1LhIDBqyd0foTwMa vCUAXOMccxn2ngXoZOzmTS4WmqUYUH3tIg4+EnYYVdLxtyZveA/Dx+IK1u7Kog== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pl5RK377dzsfv; Sun, 26 Mar 2023 19:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32QJLnPH079201; Sun, 26 Mar 2023 19:21:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32QJLn4M079200; Sun, 26 Mar 2023 19:21:49 GMT (envelope-from git) Date: Sun, 26 Mar 2023 19:21:49 GMT Message-Id: <202303261921.32QJLn4M079200@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: ec1bc530027f - main - arm64: cpu_switch: don't zero out pcb_onfault List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ec1bc530027f0f17cd7f3979b5df85fdd57a461f Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=ec1bc530027f0f17cd7f3979b5df85fdd57a461f commit ec1bc530027f0f17cd7f3979b5df85fdd57a461f Author: Kyle Evans AuthorDate: 2023-03-26 18:48:22 +0000 Commit: Kyle Evans CommitDate: 2023-03-26 18:48:22 +0000 arm64: cpu_switch: don't zero out pcb_onfault Previously this would zero out x18 in the pcb, now it's attacking the innocent pcb_onfault -- drop it entirely. This technically fixes e605b87a9e7 ("Save only callee-saved registers in pcb"), but it's harmless until the below commit trims down pcb_x. Reported by: mmel Reviewed by: andrew, mmel Fixes: 1c1f31a5e517 ("Remove unused registes from the arm pcb") Differential Revision: https://reviews.freebsd.org/D39277 --- sys/arm64/arm64/swtch.S | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/arm64/arm64/swtch.S b/sys/arm64/arm64/swtch.S index 538235d7b3e8..656ab9c864b7 100644 --- a/sys/arm64/arm64/swtch.S +++ b/sys/arm64/arm64/swtch.S @@ -203,7 +203,6 @@ ENTRY(cpu_switch) ldp x27, x28, [x4, #PCB_REGS + (PCB_X19 + 8) * 8] ldp x29, lr, [x4, #PCB_REGS + (PCB_X19 + 10) * 8] - str xzr, [x4, #PCB_REGS + 18 * 8] ret END(cpu_switch)