From owner-svn-src-all@FreeBSD.ORG Fri May 11 13:09:11 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A2C81065673; Fri, 11 May 2012 13:09:11 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id CE5188FC08; Fri, 11 May 2012 13:09:10 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 0659814E7546; Fri, 11 May 2012 15:09:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at server.mypc.hu Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nisThTg5Tevy; Fri, 11 May 2012 15:09:09 +0200 (CEST) Received: from [192.168.1.117] (catv-80-98-232-12.catv.broadband.hu [80.98.232.12]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 70C7F14E755C; Fri, 11 May 2012 15:09:09 +0200 (CEST) Message-ID: <4FAD0F71.1080203@FreeBSD.org> Date: Fri, 11 May 2012 15:09:05 +0200 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120328 Thunderbird/13.0a2 MIME-Version: 1.0 To: Colin Percival References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua> <4FAD0DF4.9000609@freebsd.org> In-Reply-To: <4FAD0DF4.9000609@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Konstantin Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 13:09:11 -0000 On 2012.05.11. 15:02, Colin Percival wrote: > On 05/11/12 05:48, Konstantin Belousov wrote: >> >On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >>> >>+bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >>> >>unsigned char **cmonths = NULL; >> > >> >Such initializations are useless. You only increase the size of the binary >> >on the disk as the consequence. > I just tested this hypothesis, and found no change in binary size using > either clang or gcc46. Presumably they're smart enough to ignore explicit > (and unnecessary) initializations of statics to zero. Thanks Colin and thanks Konstantin for raising this doubt. I will clean these up later for better style, anyway. Gabor