From owner-freebsd-stable@FreeBSD.ORG Mon Apr 14 12:02:14 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EC9C37B404; Mon, 14 Apr 2003 12:02:14 -0700 (PDT) Received: from sccrmhc01.attbi.com (sccrmhc01.attbi.com [204.127.202.61]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70B2643FA3; Mon, 14 Apr 2003 12:02:12 -0700 (PDT) (envelope-from crist.clark@attbi.com) Received: from blossom.cjclark.org (12-234-159-107.client.attbi.com[12.234.159.107]) by sccrmhc01.attbi.com (sccrmhc01) with ESMTP id <2003041419021100100ojbbee>; Mon, 14 Apr 2003 19:02:11 +0000 Received: from blossom.cjclark.org (localhost. [127.0.0.1]) by blossom.cjclark.org (8.12.8p1/8.12.3) with ESMTP id h3EJ2Aki021882; Mon, 14 Apr 2003 12:02:10 -0700 (PDT) (envelope-from crist.clark@attbi.com) Received: (from cjc@localhost) by blossom.cjclark.org (8.12.8p1/8.12.8/Submit) id h3EJ28tZ021881; Mon, 14 Apr 2003 12:02:08 -0700 (PDT) X-Authentication-Warning: blossom.cjclark.org: cjc set sender to crist.clark@attbi.com using -f Date: Mon, 14 Apr 2003 12:02:08 -0700 From: "Crist J. Clark" To: "Robin P. Blanchard" Message-ID: <20030414190208.GA21249@blossom.cjclark.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-URL: http://people.freebsd.org/~cjc/ cc: stable@freebsd.org cc: adrian@freebsd.org Subject: Re: Ipf headers not installed per default ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Crist J. Clark" List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2003 19:02:14 -0000 On Fri, Apr 11, 2003 at 03:40:22PM -0400, Robin P. Blanchard wrote: > Just rebuilt and installed/world kernel: FreeBSD 4.8-STABLE #0: Fri Apr 11 > 14:34:37 EDT 2003 > > Using the latest Makefile for squid25: > # fgrep \$FreeBSD /usr/ports/www/squid/Makefile > # $FreeBSD: ports/www/squid/Makefile,v 1.100 2003/04/09 08:31:30 adrian Exp $ > Modified with: > # fgrep CONFIGURE_ARGS Makefile |fgrep -v \# [snip] > CONFIGURE_ARGS+= --enable-ipf-transparent This is the one that needs IPFilter headers. > The configure script does not locate IPF's header files. I had to manually > copy them over: > # cp -p /usr/src/sys/contrib/ipfilter/netinet/*.h /usr/include/netinet/ > > Squid then built fine. Should these header files be installed with the world? > Or should squid's port be modified to include /usr/src/sys/include/ipfilter ? It shouldn't look in /usr/src. Ports should (a) not expect the user to have a FreeBSD source tree or (b) demand that it be in /usr/src (although you could add a make variable that is the base of the source tree that defaults to /usr/src, if there isn't one already). The IPFilter .h-files should be installed with world. Whether they belong in /usr/include/netinet or somewhere else is a different matter. Without digging into the CVS repo, I'd venture to guess that this happened when IPFitler files got separated out of the src/sys tree into src/sys/contrib/ipfilter. Why don't you send in a PR on this? -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org