From owner-freebsd-hackers Mon Oct 30 00:33:08 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA12020 for hackers-outgoing; Mon, 30 Oct 1995 00:33:08 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id AAA12015 for ; Mon, 30 Oct 1995 00:33:06 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id AAA00327; Mon, 30 Oct 1995 00:33:04 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id AAA00376; Mon, 30 Oct 1995 00:32:39 -0800 Message-Id: <199510300832.AAA00376@corbin.Root.COM> To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) cc: andreas@knobel.gun.de (Andreas Klemm), hackers@freebsd.org Subject: Re: several diffs for dump(8) to display write throughput and such...c In-reply-to: Your message of "Mon, 30 Oct 95 09:19:31 +0100." <199510300819.JAA04834@uriah.heep.sax.de> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 30 Oct 1995 00:32:33 -0800 Sender: owner-hackers@freebsd.org Precedence: bulk >As Andreas Klemm wrote: >> >> > > >>DUMP: DUMP: finished in 1451 seconds, throughput 474 KBytes/sec >> > >> > Neat! I like it. However, we're already in feature freeze for 2.1 so >> > this would definitely be -current fodder only, I'm afraid! >> >> Hi Jordan, well, that's fine. So you take the part to fiddle it in >> into current, please ?! > >I've already wrote this to Andreas in private mail: > >o The patch could cause a division by 0 under rare circumstances, it > divides by a time difference without first checking for 0. The > probably best way is to add a `1' there. It won't change the result > very significantly for a long-term tape backup, but avoids the > problem. It should check for zero. -DG