From owner-p4-projects@FreeBSD.ORG  Wed Nov  1 23:05:39 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1623316A417; Wed,  1 Nov 2006 23:05:39 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AA9DB16A415;
	Wed,  1 Nov 2006 23:05:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2358043D5A;
	Wed,  1 Nov 2006 23:05:37 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kA1N5YmM005380;
	Wed, 1 Nov 2006 18:05:34 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Roman Divacky <rdivacky@freebsd.org>
Date: Wed, 1 Nov 2006 16:25:27 -0500
User-Agent: KMail/1.9.1
References: <200611011958.kA1JwQbN022477@repoman.freebsd.org>
In-Reply-To: <200611011958.kA1JwQbN022477@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200611011625.28582.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Wed, 01 Nov 2006 18:05:34 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2143/Wed Nov 1 17:03:47 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 108941 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Nov 2006 23:05:39 -0000

On Wednesday 01 November 2006 14:58, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=108941
> 
> Change 108941 by rdivacky@rdivacky_witten on 2006/11/01 19:57:42
> 
> 	Lock proc in gettid.
> 
> Affected files ...
> 
> .. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#22 edit
> 
> Differences ...
> 
> ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#22 
(text+ko) ====
> 
> @@ -1408,7 +1408,9 @@
>  		printf(ARGS(gettid, ""));
>  #endif
>  
> +	PROC_LOCK(td->td_proc);
>  	td->td_retval[0] = td->td_proc->p_pid;
> +	PROC_UNLOCK(td->td_proc);
>  	return (0);
>  }

You don't need this.  p_pid is read-only after fork().

-- 
John Baldwin