From owner-cvs-all  Sat Jan 23 19:42:56 1999
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA01761
          for cvs-all-outgoing; Sat, 23 Jan 1999 19:42:56 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA01754;
          Sat, 23 Jan 1999 19:42:55 -0800 (PST)
          (envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.2/8.9.1) id TAA57652;
	Sat, 23 Jan 1999 19:42:38 -0800 (PST)
	(envelope-from dillon)
Date: Sat, 23 Jan 1999 19:42:38 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199901240342.TAA57652@apollo.backplane.com>
To: David Greenman <dg@root.com>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c 
References:  <199901240328.TAA13629@implode.root.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

:
:>dillon      1999/01/23 17:15:58 PST
:>
:>  Modified files:
:>    sys/kern             uipc_syscalls.c 
:>  Log:
:>       There was a situation where sendfile() might attempt to initiate I/O
:>       on a PG_BUSY page, due to a bug in its sequencing of a conditional.
:
:   Huh? Would you please explain this further?

    The original conditional was:

   if (pg == NULL || (!(pg->flags & PG_BUSY) && !pg->busy &&
	   !vm_page_is_valid(pg, pgoff, xfsize))) {

	...
	... wire page and start I/O ...
    } else {
	... wait for page ...
    }

     Hmmm.  lemme read this again.  Oops, I think you are
     right, that wasn't a bug.  Well, consider keeping the new
     code anyway, it's more readable then the old code.

					-Matt

:-DG
:
:David Greenman
:Co-founder/Principal Architect, The FreeBSD Project
:
:

					Matthew Dillon 
					<dillon@backplane.com>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message