From owner-cvs-all@FreeBSD.ORG Fri May 25 01:22:07 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 34AF016A421 for ; Fri, 25 May 2007 01:22:07 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.183]) by mx1.freebsd.org (Postfix) with ESMTP id D19AC13C48A for ; Fri, 25 May 2007 01:22:06 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by py-out-1112.google.com with SMTP id a29so1174868pyi for ; Thu, 24 May 2007 18:22:06 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=jeClXaelNEARQTkH7J1lEfvHdoSnSC/2UQ16WQFi30fprnVFOGyzdS7dMYQG4ailZPA42pnv6G37JTrI7dct0L5UJsL5JlgAhgtiClIvQNtz/tuAA/ISOSmLfZEdNSSSsO3LPGDsKXC+xjxKjX8UnuNe6tgWy9v75uUwU35GhyI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=T418zdhfxFfaY6QU+p7l0BgEixdtoVr4UgQ3cQilP1xtw4n+9i1BNEftQwyA6nfqO/ZLlCdGtAGMJyoZrJjzdOw98JX8dXu0utQNjVGVPJMfV8Ttt+UL/gxCl9g/QkBnn55Hhwe5iHXKRpodg9/h/8UpYkKytcvifrvzTui5k+A= Received: by 10.35.27.2 with SMTP id e2mr1224617pyj.1180054388451; Thu, 24 May 2007 17:53:08 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id 10sm2980319nzo.2007.05.24.17.53.04; Thu, 24 May 2007 17:53:06 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l4P0r0DR054014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 May 2007 09:53:00 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l4P0qxE8054013; Fri, 25 May 2007 09:52:59 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Fri, 25 May 2007 09:52:59 +0900 From: Pyun YongHyeon To: Jack F Vogel Message-ID: <20070525005259.GA53688@cdnetworks.co.kr> References: <200705241811.l4OIBCUI018049@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705241811.l4OIBCUI018049@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2007 01:22:07 -0000 On Thu, May 24, 2007 at 06:11:11PM +0000, Jack F Vogel wrote: > jfv 2007-05-24 18:11:11 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Fix for PR 112937, thanks to Ruslan Ermilov. I am still > a bit confused how the 'link flap' was connected to the > 'get' rather than 'set' address, but this seems the right > thing to do here. > Thanks for the fix. The bug was introduced by me and it was just a hack to suppress hardware reinitialization. I know lots of ethernet drivers do this kind of hardware reinitailization whenever alias addresses are added. I guess we should reinitialize the hardware only when it's absolutely required. Fixing ether_ioctl() to invoke if_init only when the interface is not running would remove the hack but I'm not sure how it would affect configuraing multicasting filters in ethernet drivers. -- Regards, Pyun YongHyeon