From owner-freebsd-hackers@FreeBSD.ORG Sun Dec 19 17:42:03 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C9031065670; Sun, 19 Dec 2010 17:42:03 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 572128FC15; Sun, 19 Dec 2010 17:42:01 +0000 (UTC) Received: by wyf19 with SMTP id 19so2134204wyf.13 for ; Sun, 19 Dec 2010 09:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=Q1s+x1ahqmS834RBD8yOl12ReuZwhl1vwsJWy24kWiE=; b=QMA8nj7AIfbXMQuIEUbq2mjiVTPBd2NH4tvPz0gdQoVOt/X/qwpcTYnttcvC9hz9XW /K+0IAj156tv+is4e3UDyRVtuyHSW+hKrFsweaMkqyUyC2RCTqWzou0gb/n7TejoFZ0A cORQhjSn5YuliqF95h1QyqkHDALh2HsQ5reSs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=wlZ1U2x0HFxuWSk6M6uzRaS5pspiZ27u73lS7+IcprMq+Y6m2KxhMjupXT3mLP6SQs ISHsajkEt0J9w05Yj9BuATQh0gzIrRgepFH2/1KE1lJ+O6ICBZmRyq/GeVAcfXxFnv6F 8cBTUFnuYPHWxMIO+h907OWNpboqWFCFuDyRs= MIME-Version: 1.0 Received: by 10.216.186.138 with SMTP id w10mr3855233wem.1.1292780521241; Sun, 19 Dec 2010 09:42:01 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.254.226 with HTTP; Sun, 19 Dec 2010 09:42:01 -0800 (PST) In-Reply-To: <20101219112356.GA18388@freebsd.org> References: <20101219112356.GA18388@freebsd.org> Date: Sun, 19 Dec 2010 09:42:01 -0800 X-Google-Sender-Auth: Q4o9E3VSAMNbXC3fFDrWreUT7aA Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org Subject: Re: getting rid of some -mno-* flags under sys/boot X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Dec 2010 17:42:03 -0000 On Sun, Dec 19, 2010 at 3:23 AM, Alexander Best wrote: > hi there, > > i think some of the -mno-* flags in sys/boot/* can be scrubbed, since they're > already being included from ../Makefile.inc. Looks good. > also TARGET cleandir leaves some files behind in i386/gptboot which should be > fixed by this patch. AHA. This might fix the issue I've seen rebuilding stuff with gptzfsboot for a good while now where I have to (on mostly rare occasions with -j24, etc typically after updating my source tree) rebuild it manually. gptzfsboot and zfsboot also need the fix, BTW. The only thing is that these files live under the common directory, so shouldn't common clean them up (I see that common doesn't have a Makefile though, only a Makefile.inc -- ouch)? FWIW though, wouldn't it be better to avoid this accidental bug and unnecessary duplication by doing something like the following? # ... OBJS= zfsboot.o sio.o gpt.o drv.o cons.o util.o CLEANFILES+= gptzfsboot.out ${OBJS} gptzfsboot.out: ${BTXCRT} ${OBJS} # ... Thanks, -Garrett