From owner-svn-src-head@freebsd.org Thu Mar 12 17:55:56 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DBBED2671C7; Thu, 12 Mar 2020 17:55:56 +0000 (UTC) (envelope-from bdragon@imap.cc) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48dc243GJpz4Kkp; Thu, 12 Mar 2020 17:55:56 +0000 (UTC) (envelope-from bdragon@imap.cc) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 80C6D2220A; Thu, 12 Mar 2020 13:55:54 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute3.internal (MEProxy); Thu, 12 Mar 2020 13:55:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imap.cc; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm2; bh=LliayhrfTwiRUaKu2MZysRWPUzsoZNG EJgEGf9oFSWQ=; b=qhrVsLSvujMPpMw/Wf8FVRL5KDhZ3LdWN0mLJJZ5eVCMCS8 RBqb31oKV2a0Np/ISrF4ukKYyC+UFWrK1iFcsoRZKrDvMylxs+KWVgZ/djApHBr2 0WUTRT9cVd+9ZqLCU9YnezaKL+U4ncebSxU2+GL6IV/z8tS4tYBDXjlF6CbYSou+ Pygx7kxAUOe8H8neudYqEeyAqdDeppgS+Y/dvwpuaunX3+OG1HDEE/7t5Yhf20Rx bn/3h4MnmgYqYzOw5yKxeMRADYGoY1bEngr432aRXVmQ3BHxeYEcZak+p607X5LO +FpgYaH4MdWNLDjVTYivAJcFwrFcTsGdyOSOcoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Lliayh rfTwiRUaKu2MZysRWPUzsoZNGEJgEGf9oFSWQ=; b=DFGJx+K3JuBXfIgu/osrCk bs1FeO3joLvw3VNvio7z6PqI11B6iWWKi4eOpRgq2b215g8TpO+tTfARLKO1dFPM MmYSHxyRZ1tp2vT67xT5XzNaMfiBJB9JoF58q/bAsmsu7dCdsGpa270/EUNS9KIm AIGvqX0iPx5q4B6PqITDKijSGsiwzxVq/4RIEd3mmgf5S3hrGxSAevkxuPVFZxZq Dx8dcDx/DDXd9IDfQgZy2rYh2Qt0bUFEM7pb65EbbaZFYFB0CUKsc2/UtoLbyF71 GcLmUUm5+brbAjQim9iBcegHY8VEmh/8/KcOk38aCGFv1WpC2e8fhyd0x6IxqKSQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvhedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddutddmnecujfgurhepof gfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdeurhgrnhguohhnuceu vghrghhrvghnfdcuoegsughrrghgohhnsehimhgrphdrtggtqeenucffohhmrghinhepfh hrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpegsughrrghgohhnsehimhgrphdrtggt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 2809FC200A5; Thu, 12 Mar 2020 13:55:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-991-g5a577d3-fmstable-20200305v3 Mime-Version: 1.0 Message-Id: In-Reply-To: <202003112334.02BNYiZs010229@repo.freebsd.org> References: <202003112334.02BNYiZs010229@repo.freebsd.org> Date: Thu, 12 Mar 2020 12:55:33 -0500 From: "Brandon Bergren" To: "Brandon Bergren" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358902 - head/lib/libc/powerpc64/string Content-Type: text/plain X-Rspamd-Queue-Id: 48dc243GJpz4Kkp X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.63 / 15.00]; NEURAL_HAM_MEDIUM(-0.63)[-0.630,0]; NEURAL_HAM_LONG(-1.00)[-0.996,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 17:55:57 -0000 To be clear here, I meant non qword-aligned, as it was the VSX implementation that was actually tripping up here. The problem manifested when the source and destination didn't match on the least significant nybble. Apparently it's also somewhat uncommon for programs to ever do anything with the return value as well. On Wed, Mar 11, 2020, at 6:34 PM, Brandon Bergren wrote: > Author: bdragon > Date: Wed Mar 11 23:34:44 2020 > New Revision: 358902 > URL: https://svnweb.freebsd.org/changeset/base/358902 > > Log: > Fix r358688 -- Remember to actually save r3 before processing. > > Crash was noticed by pkubaj building gcc9. > > Apparently non dword-aligned char pointers are somewhat rare in the wild. > > Reported by: pkubaj > Sponsored by: Tag1 Consulting, Inc. > > Modified: > head/lib/libc/powerpc64/string/memcpy.S > > Modified: head/lib/libc/powerpc64/string/memcpy.S > ============================================================================== > --- head/lib/libc/powerpc64/string/memcpy.S Wed Mar 11 22:25:45 2020 (r358901) > +++ head/lib/libc/powerpc64/string/memcpy.S Wed Mar 11 23:34:44 2020 (r358902) > @@ -58,8 +58,8 @@ ENTRY(FN_NAME) > andi. %r7, %r4, ALIGN_MASK > cmpd %r8, %r7 > mr %r7, %r5 > - bne .Lcopy_remaining_fix_index_byte > mr %r8, %r3 /* save dst */ > + bne .Lcopy_remaining_fix_index_byte > > /* align src */ > .Lalignment_loop: > -- Brandon Bergren bdragon@imap.cc