From owner-freebsd-arch@FreeBSD.ORG Sun Dec 2 17:43:58 2007 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7031316A421 for ; Sun, 2 Dec 2007 17:43:58 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 2CDB413C46E for ; Sun, 2 Dec 2007 17:43:57 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 3BDEB17105; Sun, 2 Dec 2007 17:43:56 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id lB2HhtGC045309; Sun, 2 Dec 2007 17:43:55 GMT (envelope-from phk@critter.freebsd.dk) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 02 Dec 2007 09:36:03 MST." <20071202.093603.228972203.imp@bsdimp.com> Date: Sun, 02 Dec 2007 17:43:54 +0000 Message-ID: <45308.1196617434@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: arch@FreeBSD.org Subject: Re: New "timeout" api, to replace callout X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2007 17:43:58 -0000 In message <20071202.093603.228972203.imp@bsdimp.com>, "M. Warner Losh" writes: >In message: <19827.1196612123@critter.freebsd.dk> > "Poul-Henning Kamp" writes: >: In message <20071202.085545.177225588.imp@bsdimp.com>, "M. Warner Losh" writes: >: >: >There are a number of places in the tree that use a parameter of '1' >: >today to mean "next time that's convenient." Some of these places are >: >clever and know that HZ is never < 100 or > 1000 (or so they think), >: >while others are just sloppy code. >: >: Yes, but those can hardly be called "concrete" in terms of wanting >: to know what they mean, can they ? :-) >: >: The only way I can see we can deal with them in the short term, >: is to ask for timeouts of "1000000 / hz, TIMEOUT_USEC" > >Or have a "timeout_soon" function like you have the other timeout >conversion routines. I'm not very keen on offering too much rope. Intelligent decisions need to be made about these polling rates and making it too easy to not think about it would be to encourage bad practices. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.