From owner-freebsd-bugs@freebsd.org  Sun Sep 17 03:43:22 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61951E1FD93
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sun, 17 Sep 2017 03:43:22 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3709D701A5
 for <freebsd-bugs@FreeBSD.org>; Sun, 17 Sep 2017 03:43:22 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8H3hMXZ081931
 for <freebsd-bugs@FreeBSD.org>; Sun, 17 Sep 2017 03:43:22 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 222234] head -r323246 aarch64 (Pine64+ 2GB) boot time context,
 sometimes: acquiring blockable sleep lock with spinlock or critical section
 held
Date: Sun, 17 Sep 2017 03:43:22 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: markmi@dsl-only.net
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-222234-8-n3bD75RZFM@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-222234-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-222234-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Sep 2017 03:43:22 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222234

--- Comment #4 from Mark Millard <markmi@dsl-only.net> ---
(In reply to Mark Millard from comment #2)

There appears to be another potential
example of the lack of dsb before sev
for aarch64:

identcpu.c has:

void
identify_cpu(void)
{
. . .
        if (cpu !=3D 0) {
                /*
                 * This code must run on one cpu at a time, but we are
                 * not scheduling on the current core so implement a
                 * simple spinlock.
                 */
                while (atomic_cmpset_acq_int(&ident_lock, 0, 1) =3D=3D 0)
                        __asm __volatile("wfe" ::: "memory");
. . .
                /* Wake up the other CPUs */
                atomic_store_rel_int(&ident_lock, 0);
                __asm __volatile("sev" ::: "memory");
        }
}

vs. as shown in the patch for release_aps :

# svnlite diff /usr/src/sys/arm64/arm64/mp_machdep.c=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
                           Index: /usr/src/sys/arm64/arm64/mp_machdep.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- /usr/src/sys/arm64/arm64/mp_machdep.c       (revision 323246)
+++ /usr/src/sys/arm64/arm64/mp_machdep.c       (working copy)
@@ -236,7 +236,9 @@

        atomic_store_rel_int(&aps_ready, 1);
        /* Wake up the other CPUs */
-       __asm __volatile("sev");
+       __asm __volatile(
+           "dsb  ish   \n"
+           "sev        \n");

        printf("Release APs\n");


One difference vs. the origin release_aps
text is the notation:

 ::: "memory"

in identify_cpu . I'm not expert in the relevant
notation and its usage/intent.

--=20
You are receiving this mail because:
You are the assignee for the bug.=