From owner-freebsd-current@FreeBSD.ORG Sun Nov 20 17:43:59 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56F4816A41F for ; Sun, 20 Nov 2005 17:43:59 +0000 (GMT) (envelope-from joseph.koshy@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id A79BD43D45 for ; Sun, 20 Nov 2005 17:43:58 +0000 (GMT) (envelope-from joseph.koshy@gmail.com) Received: by xproxy.gmail.com with SMTP id s9so471711wxc for ; Sun, 20 Nov 2005 09:43:58 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=dM1dBU/pLq5f3qwD3FWuUDkK5Ho9JxQBWZ6ENo3TInTNM5aqizNVOD9QkNk2aQgE19eVt0mgJY29VxPn3/VkbdJ6pGI2x5HB01Al+KHesmXuqBgwzIFR7K+3FNC/gjrpFn2cMvk2JrnoNHf4U5kNW9gGGPocaLj/vHlUNl1QSo0= Received: by 10.70.29.8 with SMTP id c8mr1356785wxc; Sun, 20 Nov 2005 09:43:58 -0800 (PST) Received: by 10.70.105.13 with HTTP; Sun, 20 Nov 2005 09:43:58 -0800 (PST) Message-ID: <84dead720511200943ua2cf8b8y49bff0dcf3e2fa63@mail.gmail.com> Date: Sun, 20 Nov 2005 23:13:58 +0530 From: Joseph Koshy To: "Wojciech A. Koszek" In-Reply-To: <20051120172755.GA85641@freebsd.czest.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20051120172755.GA85641@freebsd.czest.pl> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Specifying alternative file for devd(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2005 17:43:59 -0000 wk> http://freebsd.czest.pl/dunstan/FreeBSD/diff.0.devd wk> Comments are welcome! Manual page comments: -->><<-- +.It Fl f Ar file +Use file as configuration file instead of /etc/devd.conf (default). "Use configuration file .Ar file instead of the default .Pa /etc/devd.conf ." -->><<-- +(or alternative file specified with +.Fl f +flag) and uses that file to drive the rest of the process. While the +format of this file is described in ".Fl f option" is clearer. Flags usually are booleans. Sentences start on a new line. -->><<-- diff -upr /usr/src/sbin/devd/devd.cc src/sbin/devd/devd.cc --- /usr/src/sbin/devd/devd.cc=09Mon Nov 14 03:01:10 2005 +++ src/sbin/devd/devd.cc=09Sun Nov 20 18:07:08 2005 You should probably also mention in the manual page that only one (the last) '-f' option has an effect. The manual page also needs a .Sh FILES section that lists /etc/devd.conf. Otherwise the patch looks fine. -- FreeBSD Volunteer, http://people.freebsd.org/~jkoshy