From owner-cvs-all Thu Feb 7 15:39: 5 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id 790A937B404; Thu, 7 Feb 2002 15:38:56 -0800 (PST) Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020207233856.NVNH2951.rwcrmhc53.attbi.com@peter3.wemm.org>; Thu, 7 Feb 2002 23:38:56 +0000 Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g17Ncus87638; Thu, 7 Feb 2002 15:38:56 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id C793239F1; Thu, 7 Feb 2002 15:38:55 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Julian Elischer Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha db_trace.c locore.s machdep.c pmap.c prom.c sys_machdep.c vm_machdep.c src/sys/alpha/linux linux_machdep.c linux_sysvec.c src/sys/alpha/osf1 imgact_osf1.c src/sys/compat/pecoff imgact_pecoff.c src/sys/ddb db_ps.c ... In-Reply-To: Date: Thu, 07 Feb 2002 15:38:55 -0800 From: Peter Wemm Message-Id: <20020207233855.C793239F1@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Julian Elischer wrote: > > > On Thu, 7 Feb 2002, Andrew Gallatin wrote: > > > > > > > Peter Wemm [peter@wemm.org] wrote: > > > Julian Elischer wrote: > > > > julian 2002/02/07 12:58:48 PST > > > > > > > Reviewed by: peter@freebsd.org, gallatin@cs.duke.edu, benno rice, > > > > > > NO! This was *NOT* reviewed by me. I haven't even *seen* it! > > Ummm we spent two hours together on the phone going through these > changes... No, that was the kse diff, on sunday.. You had not even started this diff then. I said on many occasions during that readthrough that there were problems that should be fixed before committing, and that both you and I would read through the diff before it was committed, since it is blatently obvious where the mistakes are. This kind of thing stands out like a sore thumb: @@ -2331,15 +2332,18 @@ ttyprintf(tp, "empty foreground process group\n"); else { mtx_lock_spin(&sched_lock); + /* Pick interesting process. */ for (pick = NULL; p != 0; p = LIST_NEXT(p, p_pglist)) if (proc_compare(pick, p)) pick = p; Maybe I overreacted. Dealing with pacbell is not a good way to calm the nerves. But I also don't appreciate being listed as a reviewer when I haven't even seen the actual change, and when I explicitly said "let me read it first". Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message