From nobody Wed Feb 5 20:59:46 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpCKb1CP0z5mPF5; Wed, 05 Feb 2025 20:59:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpCKb0hxrz3X5q; Wed, 05 Feb 2025 20:59:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738789187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OHHZjgpzcB+TeuqUcelMufYF+U96Wa66R0lR6uNpc0s=; b=u3szIBKEb+wm/8bkeDusLnz/CCQFPoAj7FbM4Ceu4OzYJFvoJB+EHUD8QxkI2auaY0Qgdf rfB+MoHiJeInqND366pzF5NdMcE7YWcSH0NURqZpeKuxWI7N5K2eeTETyiZLirmrbqZ74a VfE9hnMgcVoQasH6/+FKu8nw1Lh01Swdr5ZK+PP2b7KdTtlP/M38HUDCqBsmJgt4DoLGIM jqVnBp7OivB3NuCZjlFnO5UmB/priQRuaCBh48EMg5qYN9J9WS3L64+GYJ4fFUa9cLtQWL aPQvSUBvdIAeVBHdL0Q8Ak8nMhhMyxF+zORPP0iyVJRDQZU8Mg+wg56Dt1U6FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738789187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OHHZjgpzcB+TeuqUcelMufYF+U96Wa66R0lR6uNpc0s=; b=p5Ma2xtLfbh4LeN1bpxvPXL3ndfG773+iJCMSE9lZTjwtTMXICF12mzrMm2dW7xP5hqTV2 g+tJgxg+cUv59jTbCpRua/lMCcOD/w8QIfAPN65wylB/1+bU91k1IdLxLO9sRRFE7p5YFm 3jF8pWgZwemdLXw+3LKCQPgoPWHP3ZWAqQWm+8TLabtUWFUVMe+OQIBHPIXoo5Q7R10xk0 1V3QdoTYHOMQfHb7eOoaRSShQiSnZRjh3EhGDgRq3mtYbmP681laWGdevTS/pakvSNX0Xf /e/nhaHV8VqFUT1j5vM9t/wHTOTHKH9jILCiUl2HEVCX1mhlK2IDNVoIki+fjg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738789187; a=rsa-sha256; cv=none; b=aQKMXWpm6NxslycN17TvkfCqw0oVNiMJrMmkuTSM1k3vBFhCoNt2e1YskLICYJ7vW57XBY va6+Lq/rc0nYyHe4EumlC/FlrTR4rxhOeGi4genAjFWhnESbghMKTOCp9JFOIE/gLcH00t uFS6M5YbLtE7IYVdKSBCFXaL1XcWkOfEA9Y7RtcbKli4HJEE2hfWTgmAow0xeZvjml+PR0 e5AiNPxfX3iwY5QwgwUmaIbNsBW5lo1GU37lJtjONYty384FmPvnjlChOMLq6CTc2qwHHd XRomMGvCEKQtXxWRb1KZ7iU/dJFOnXg3s5qKjugKLEUJTpFPWOCyDB36RAe6jg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YpCKZ6tH4z176f; Wed, 05 Feb 2025 20:59:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515Kxkex006004; Wed, 5 Feb 2025 20:59:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515Kxkqx006001; Wed, 5 Feb 2025 20:59:46 GMT (envelope-from git) Date: Wed, 5 Feb 2025 20:59:46 GMT Message-Id: <202502052059.515Kxkqx006001@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 0cc48e631781 - stable/14 - TCP RACK: don't log an uninitialized value List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0cc48e6317819a1ed2bba523b7014940ef2f9b61 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0cc48e6317819a1ed2bba523b7014940ef2f9b61 commit 0cc48e6317819a1ed2bba523b7014940ef2f9b61 Author: Michael Tuexen AuthorDate: 2025-01-08 22:15:54 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 10:00:04 +0000 TCP RACK: don't log an uninitialized value reduce is uninitialized, if the code path for logging is reached via goto old_method;. Reviewed by: rrs, Peter Lei CID: 1557359 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48346 (cherry picked from commit 4c89d59e0cdac4d83fb5841aefae9214545b2273) --- sys/netinet/tcp_stacks/rack.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 2fefcdcbf01d..fd8054febb54 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17699,7 +17699,7 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str * the peer to have a gap in data sending. */ uint64_t cwnd, tr_perms = 0; - int32_t reduce = 0; + int32_t reduce; old_method: /* @@ -17736,7 +17736,8 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str slot -= reduce; } else slot = 0; - } + } else + reduce = 0; slot *= HPTS_USEC_IN_MSEC; if (rack->rc_pace_to_cwnd) { uint64_t rate_wanted = 0;