From nobody Fri Apr 14 11:21:04 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PyYsr6Cxhz453Mk for ; Fri, 14 Apr 2023 11:21:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PyYsr4RD0z3wcc for ; Fri, 14 Apr 2023 11:21:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681471264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y9Z3dRIt5n1Q4EJBJksaqRIztoj0vU7gOpxRL4HZJ0I=; b=fAyv3LS6y53w2l2sKAbgb1mmqvaOvmqOSWMZ4Z8VgAdAOBunygV8Q4+yWyCDvEeANAv3pD pplT+uat9pmGj3Mv1dbz0ZBPpSQ97V9J3MBOV5jifZxILrzGUbWfXoDn62sE6OjL5lk9s3 dQSNXzmUs8d/MpGWH9qaVdXmHdAY8WQ6o3GDK3xmbEAcJoa7J+B2tY74HId1NL5VLZD76L 8nx26LGerHt//ISoIpVV78dbjbi7Oi629delJvbe77VBPI18unSgxAkWwaKEc7NaNextV9 L/S6Mk6izzZzyDSQkCbPS3UDIw8jduKtKWJHBJHdpTKty21qvi7bMiIe+ezoug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681471264; a=rsa-sha256; cv=none; b=h6vvte1ysgWZqW94TMhF7gr7w7VyoiiAFbceQZVERDI2sFX67OFKvKxBifA9a4yWAOwqZI 7RkDGgoMLiJuxy7CKGGbNXrkXHqvInGCEZ2rfjzMcaTnUDo4aNUNgyzGvmbpDQata5V3Qc 4G+zduC2+2sPqml3T9g7ZyYuhlizHBO0itDSyvSnF3LRTyt6VTky6GkAB6SjirW3Q4n3Hb eKCMWJWbW0118x97HF0JScvlg3bHWWHh1LCGl+yMUOGuQnOuw1EtVnl+80WTWxviwSzEXI D3WX6sIuRjNchL6BbNRkAtHnXC1KfUAG5iF3DIZKoVnCln6qaTzzFRUKwqlfvw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PyYsr3Y9xzMVc for ; Fri, 14 Apr 2023 11:21:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33EBL4mn063886 for ; Fri, 14 Apr 2023 11:21:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33EBL4PQ063885 for net@FreeBSD.org; Fri, 14 Apr 2023 11:21:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 270559] if_bridge: does not forward packets properly for vlan 1 Date: Fri, 14 Apr 2023 11:21:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270559 --- Comment #11 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db0e38a1373c087e5a55eefcdee69ccfbf= 12f86ce commit b0e38a1373c087e5a55eefcdee69ccfbf12f86ce Author: Kristof Provost AuthorDate: 2023-04-07 16:00:08 +0000 Commit: Kristof Provost CommitDate: 2023-04-14 11:17:02 +0000 bridge: distinguish no vlan and vlan 1 The bridge treated no vlan tag as being equivalent to vlan ID 1, which causes confusion if the bridge sees both untagged and vlan 1 tagged traffic. Use DOT1Q_VID_NULL when there's no tag, and fix up the lookup code by using 'DOT1Q_VID_RSVD_IMPL' to mean 'any vlan', rather than vlan 0. Note that we have to account for userspace expecting to use 0 as meaning 'any vlan'. PR: 270559 Suggested by: Zhenlei Huang Reviewed by: philip, zlei Differential Revision: https://reviews.freebsd.org/D39478 sys/net/if_bridge.c | 24 ++++++++++++++---------- sys/net/if_vlan_var.h | 5 +++++ 2 files changed, 19 insertions(+), 10 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=