From nobody Wed Feb 11 13:49:03 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB0CM4821z6RVVF for ; Wed, 11 Feb 2026 13:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB0CM13Jnz3ZgV for ; Wed, 11 Feb 2026 13:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770817743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OrcdMQ3PVM5NQMS/YfRl27rze2Pyj4jDVbKKRf6dTzo=; b=v2p0W4PsXHNuyZftd297YQJSI9AMR26kwTHyYOGxVdvet+TvTIzAK3ayvkFRXx3Y9motBl mw1wBjDTPZaRyVOuMMrdVqNvhkgmHccQQnzj8kkpNJOZ5HJM++kWi2xC/Y0vPrA98q06o4 MNuwaYS308VtauICwExBwC6iFMQ63lBH0czA1rlY53eoLYPix4/1yCVFAfe2otQ8Vgeg/H 9LZeTNUjC+Q6NzWdEuCEj4IWBYUzMMnKvyl5hOLug+KG8oCBmAwY2/GfU1a62diHdQquWp HHJuXC2c2YVxbOwmveoQBJOLZ8FMT2RQDqb4cnSAAP0inMxUJxFIMxTWCGpA6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770817743; a=rsa-sha256; cv=none; b=QTiA7fM2SeniwLdg3JDfi4NVIWm2gAzyiBR6gWhJxOA4LT5SOO1s/XgQ5HnwlpZHRH8bz2 7MQqnOUA0fHhTd1ye8T2fV2EhoHsfKFDFBhPcKjpe5IiWlkHI45v9HUPechZ3SbBO38BaI LfpinOhHeKzDAe4hMrtLPfh+bIYPJ5xBMH3d56qQx5UXn2eDV7zkLa3lxcwB7+7S6w62/G hK1TDWkRQjwXJvhu4XH3SHxRRpzhkzfd+gUnX6x9rM8kRsKesfsiDbqpEXgimdhTXz6hBZ w3MSW2ndlcW7eAZVudlOk9FZT7SBhrnErkCKNOebNKKzi09mr2LoqIUvU+eKOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770817743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OrcdMQ3PVM5NQMS/YfRl27rze2Pyj4jDVbKKRf6dTzo=; b=c+IaTf6HrsQAyrx6qPXWAkvybyb23ybWef+0txKUte3tZvyYp88mS/jJE6AhJWPaOaxWaj xRzvfPIICAhOWMPd59FuePBQ0mRVCli+Hha2bx2rj0513QFzHnniTjtvYm4rcTSzcRupST 5xYRLNQuQvgqJhA8fCViBqrwPkgWk6M3I9vSw/sY2zhJxTGPZuWVpHsiLRQZFES4h+MMqB 2S4QbgEd9mEok8TN3NVNLESSIH7t8D7UhsPHgzJrcTTxL9T4X6kfsiBjb68dNgUR+5lgJl HGR7YW1uwMWKolMVN4TUVAI2W5zmDwwq5w/L0/lcYp0NRsrwElCpaMBY+i5QqQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB0CM0KcgzsK5 for ; Wed, 11 Feb 2026 13:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3be0f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 13:49:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 7d7cee09b9a4 - stable/14 - qlnxe: Remove a pointless copy back from the link-layer address List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7d7cee09b9a4ac5cbcbac79cb7ccfef5d6db1e0f Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 13:49:03 +0000 Message-Id: <698c88cf.3be0f.8469e93@gitrepo.freebsd.org> The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=7d7cee09b9a4ac5cbcbac79cb7ccfef5d6db1e0f commit 7d7cee09b9a4ac5cbcbac79cb7ccfef5d6db1e0f Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-11 13:48:07 +0000 qlnxe: Remove a pointless copy back from the link-layer address On ifnet attaching, ether_ifattach() makes the link-layer address by shadow copying the ha->primary_mac. Well, the link-layer address will not be altered during attaching, thus it is pointless to copy it back. No functional change intended. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54883 (cherry picked from commit 4ac3081b282800158df7abe93f307d76e1b5b808) (cherry picked from commit 23ffd1650cc431e762387d384ede99ae085bc130) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 99110e5e2d8f..9616d9f4d611 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2392,8 +2392,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); ether_ifattach(ifp, ha->primary_mac); - bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - QL_DPRINT2(ha, "exit\n"); return;