From owner-svn-src-projects@FreeBSD.ORG Fri Jan 23 00:34:41 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 75CCBF68; Fri, 23 Jan 2015 00:34:41 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 363A7DD0; Fri, 23 Jan 2015 00:34:40 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t0N0YX1x099600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Jan 2015 16:34:33 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t0N0YXDp099599; Thu, 22 Jan 2015 16:34:33 -0800 (PST) (envelope-from jmg) Date: Thu, 22 Jan 2015 16:34:33 -0800 From: John-Mark Gurney To: Garrett Cooper Subject: Re: svn commit: r277543 - projects/ifnet/sys/net Message-ID: <20150123003433.GG1949@funkthat.com> References: <201501230002.t0N02R5W099367@svn.freebsd.org> <21EFD3A7-91CA-4FF9-BD84-C6AD847A11ED@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21EFD3A7-91CA-4FF9-BD84-C6AD847A11ED@gmail.com> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Thu, 22 Jan 2015 16:34:33 -0800 (PST) Cc: svn-src-projects@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 00:34:41 -0000 Garrett Cooper wrote this message on Thu, Jan 22, 2015 at 16:18 -0800: > On Jan 22, 2015, at 16:02, Gleb Smirnoff wrote: > > > Author: glebius > > Date: Fri Jan 23 00:02:26 2015 > > New Revision: 277543 > > URL: https://svnweb.freebsd.org/changeset/base/277543 > > > > Log: > > Return EOPNOTSUPP in case of not supported option. > > > > Modified: > > projects/ifnet/sys/net/if_ethersubr.c > > > > Modified: projects/ifnet/sys/net/if_ethersubr.c > > ============================================================================== > > --- projects/ifnet/sys/net/if_ethersubr.c Thu Jan 22 23:59:35 2015 (r277542) > > +++ projects/ifnet/sys/net/if_ethersubr.c Fri Jan 23 00:02:26 2015 (r277543) > > @@ -985,7 +985,7 @@ ether_ioctl(struct ifnet *ifp, u_long co > > } > > break; > > default: > > - error = EINVAL; /* XXX netbsd has ENOTTY??? */ > > + error = EOPNOTSUPP; > > break; > > } > > return (error); > > Uh, didn?t you just break the ioctl(2) ERRORS guarantee? [...] > [ENOTTY] The specified request does not apply to the kind of > object that the descriptor fd references. [...] Yeh, I think ENOTTY should have been returned instead... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."