Date: Fri, 27 Jan 2012 13:58:44 +0100 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, Alan Cox <alc@rice.edu> Subject: Re: svn commit: r230572 - in head/sys/dev: ixgbe netmap Message-ID: <20120127125844.GA11690@onelab2.iet.unipi.it> In-Reply-To: <20120127203631.Q1604@besplex.bde.org> References: <201201260955.q0Q9tG1m075353@svn.freebsd.org> <4F21820B.8040000@rice.edu> <20120127203631.Q1604@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 27, 2012 at 08:45:40PM +1100, Bruce Evans wrote: > On Thu, 26 Jan 2012, Alan Cox wrote: > > >On 01/26/2012 03:55, Luigi Rizzo wrote: > > >>Log: > >>... > >> Netmap-related changes for ixgbe: > >>... > >>+#define NKR_PENDINTR 0x1 // Pending interrupt. > >> u_int nkr_num_slots; > >> > >> int nkr_hwofs; /* offset between NIC and netmap ring */ > >> struct netmap_adapter *na; // debugging > >> struct selinfo si; /* poll/select wait queue */ > >>-}; > >>+} __attribute__((__aligned__(64))); > > > >The machine-dependent param.h defines CACHE_LINE_SIZE for use in > >situations like this. > > Also, the machine-independent cdefs.h defines __aligned() for use > in situations like this. All cases that use CACHE_LINE_SIZE in an > alignment statement spell the alignment statement correctly. The > only hard-coded __attribute__() in a line matching CACHE_LINE_SIZE > is for CVMX_CACHE_LINE_SIZE in contrib/octeon-sdk/cvmx-utils.h. > Perhaps contrib'ed code needs to use hard-coded gccisms instead of > hard-coded FreeBSDisms. thanks for the comments, I'll adjust this in some subsequent commit. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120127125844.GA11690>