From owner-svn-src-all@freebsd.org Wed Jun 27 23:09:02 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62415101A713; Wed, 27 Jun 2018 23:09:02 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0A9D77F31; Wed, 27 Jun 2018 23:09:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id AA7B7520F; Wed, 27 Jun 2018 23:09:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 5E4FC9EBB; Wed, 27 Jun 2018 23:09:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id bH4M_IAHLlSL; Wed, 27 Jun 2018 23:08:57 +0000 (UTC) Subject: Re: svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/... DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 9169C9EAC To: Dimitry Andric , John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201806271929.w5RJTGwa049250@repo.freebsd.org> <1903115A-F018-4075-961A-65689595FBEE@FreeBSD.org> <0d1b366a-59ab-65e9-58a6-5474f538cad2@FreeBSD.org> <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Message-ID: <64cf10b3-d10b-77d1-f11f-b2a7c5542213@FreeBSD.org> Date: Wed, 27 Jun 2018 16:08:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 23:09:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC Content-Type: multipart/mixed; boundary="TcXLP9xI3d83lYBqekeDi8NQ0tflClLoe"; protected-headers="v1" From: Bryan Drewery To: Dimitry Andric , John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <64cf10b3-d10b-77d1-f11f-b2a7c5542213@FreeBSD.org> Subject: Re: svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/... References: <201806271929.w5RJTGwa049250@repo.freebsd.org> <1903115A-F018-4075-961A-65689595FBEE@FreeBSD.org> <0d1b366a-59ab-65e9-58a6-5474f538cad2@FreeBSD.org> <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> In-Reply-To: <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> --TcXLP9xI3d83lYBqekeDi8NQ0tflClLoe Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/27/2018 4:05 PM, Dimitry Andric wrote: > On 27 Jun 2018, at 22:53, John Baldwin wrote: >> >> On 6/27/18 12:45 PM, Bryan Drewery wrote: >>> On 6/27/2018 12:35 PM, Dimitry Andric wrote: >>>> On 27 Jun 2018, at 21:29, Bryan Drewery wrote= : >>>>> >>>>> Author: bdrewery >>>>> Date: Wed Jun 27 19:29:15 2018 >>>>> New Revision: 335733 >>>>> URL: https://svnweb.freebsd.org/changeset/base/335733 >>>>> >>>>> Log: >>>>> Don't use CCACHE for linking. >>>>> >>>>> MFC after: 2 weeks >>>>> Sponsored by: Dell EMC >>>>> >>>>> Modified: >>>>> head/bin/csh/Makefile >>>>> head/gnu/usr.bin/cc/cc1/Makefile >>>>> head/gnu/usr.bin/cc/cc1plus/Makefile >>>>> head/gnu/usr.bin/cc/cc_tools/Makefile >>>>> head/lib/libmagic/Makefile >>>>> head/lib/libpam/static_libpam/Makefile >>>>> head/lib/ncurses/ncurses/Makefile >>>>> head/share/syscons/scrnmaps/Makefile >>>>> head/stand/mips/beri/boot2/Makefile >>>>> head/usr.bin/vi/catalog/Makefile >>>>> >>>>> Modified: head/bin/csh/Makefile >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>>> --- head/bin/csh/Makefile Wed Jun 27 19:28:37 2018 (r335732) >>>>> +++ head/bin/csh/Makefile Wed Jun 27 19:29:15 2018 (r335733) >>>>> @@ -113,7 +113,7 @@ build-tools: gethost >>>>> >>>>> gethost: gethost.c sh.err.h tc.const.h sh.h ${BUILD_TOOLS_META} >>>>> @rm -f ${.TARGET} >>>>> - ${CC} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \ >>>>> + ${CC:N${CCACHE_BIN}} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICON= V//} \ >>>>> ${TCSHDIR}/gethost.c >>>> >>>> Looks like a good candidate for a common macro, say CC_NOCACHE, CC_R= EAL >>>> or something like that? :) >>> >>> Yeah probably. I'd paint it CC_LINK. >> >> CCLD was my initial thought *duck* >=20 > Actually, that is not bad, and something I have seem more often. In th= e > sense that ${LD} would be e.g. /usr/bin/ld or at least, a "low level" > linker, while ${CCLD} would be the compiler driver doing the work. > Maybe it is specifically for these cases, that you don't directly use > ${CC}, but ${CCLD}... >=20 +1 --=20 Regards, Bryan Drewery --TcXLP9xI3d83lYBqekeDi8NQ0tflClLoe-- --WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbNBkHAAoJEDXXcbtuRpfPnuQH/jLqf/yAi1FES5Zpqq2k4tnb DxPx4h7FGXXJgWRZMiNxy+fdBMlVMTi+QWZj8IMykPKLVlXPiBwaQcxmm4HItvYR PPml72RC9thPllYZyybUvs+2yzUcUT/AbITUHQcnqwtnVCMLsiMusi0oSgxLrAr2 jS8DA/spC1YQ8cPA7N5JdB5rgKMjKbjiNpsR2Uk+UizOemDnyqhQK7tR9K0X8I49 AiQLRcsZltQk2Nza1ow941kvIgBzWYsKSMlrxBYl4frhOiPE1nbxRNYHIAquNlj2 z56mmHf9OcRZ7Cu4rE7asvMLY03EpX3jp2QyFQcU1WMb6/U5IxCVbiv0slJVkqw= =TiuO -----END PGP SIGNATURE----- --WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC--