Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Feb 2012 00:08:21 +0000 (UTC)
From:      Glen Barber <gjb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r231171 - in head: etc/defaults etc/periodic/daily share/man/man5
Message-ID:  <201202080008.q1808LlN013493@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gjb (doc committer)
Date: Wed Feb  8 00:08:21 2012
New Revision: 231171
URL: http://svn.freebsd.org/changeset/base/231171

Log:
  Add an option to 404.status-zfs (enabled by default) to list all
  zfs pools on the system.
  
  While here, document daily_status_zfs_enable in periodic.conf(5).
  
  Discussed on:	-fs [1]
  Reviewed by:	netchild [1]
  Approved by:	jhb
  MFC after:	1 week
  
  [1] - http://lists.freebsd.org/pipermail/freebsd-fs/2011-June/011869.html

Modified:
  head/etc/defaults/periodic.conf
  head/etc/periodic/daily/404.status-zfs
  head/share/man/man5/periodic.conf.5

Modified: head/etc/defaults/periodic.conf
==============================================================================
--- head/etc/defaults/periodic.conf	Tue Feb  7 23:43:29 2012	(r231170)
+++ head/etc/defaults/periodic.conf	Wed Feb  8 00:08:21 2012	(r231171)
@@ -96,6 +96,7 @@ daily_status_disks_df_flags="-l -h"		# d
 
 # 404.status-zfs
 daily_status_zfs_enable="NO"				# Check ZFS
+daily_status_zfs_zpool_list_enable="YES"		# List ZFS pools
 
 # 405.status-ata_raid
 daily_status_ata_raid_enable="NO"			# Check ATA raid status

Modified: head/etc/periodic/daily/404.status-zfs
==============================================================================
--- head/etc/periodic/daily/404.status-zfs	Tue Feb  7 23:43:29 2012	(r231170)
+++ head/etc/periodic/daily/404.status-zfs	Wed Feb  8 00:08:21 2012	(r231171)
@@ -16,12 +16,21 @@ case "$daily_status_zfs_enable" in
 	echo
 	echo 'Checking status of zfs pools:'
 
-	out=`zpool status -x`
-	echo "$out"
+	case "$daily_status_zfs_zpool_list_enable" in
+	    [Yy][Ee][Ss])
+		lout=`zpool list`
+		echo "$lout"
+		echo
+		;;
+	    *)
+		;;
+	esac
+	sout=`zpool status -x`
+	echo "$sout"
 	# zpool status -x always exits with 0, so we have to interpret its
 	# output to see what's going on.
-	if [ "$out" = "all pools are healthy" \
-	    -o "$out" = "no pools available" ]; then
+	if [ "$sout" = "all pools are healthy" \
+	    -o "$sout" = "no pools available" ]; then
 		rc=0
 	else
 		rc=1

Modified: head/share/man/man5/periodic.conf.5
==============================================================================
--- head/share/man/man5/periodic.conf.5	Tue Feb  7 23:43:29 2012	(r231170)
+++ head/share/man/man5/periodic.conf.5	Wed Feb  8 00:08:21 2012	(r231171)
@@ -25,7 +25,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd December 8, 2011
+.Dd February 7, 2012
 .Dt PERIODIC.CONF 5
 .Os
 .Sh NAME
@@ -335,6 +335,28 @@ utility when
 .Va daily_status_disks_enable
 is set to
 .Dq Li YES .
+.It Va daily_status_zfs_enable
+.Pq Vt bool
+Set to
+.Dq Li YES
+if you want to run
+.Nm zpool Cm status
+on your
+.Xr zfs 8
+pools.
+.It Va daily_status_zfs_zpool_list_enable
+.Pq Vt bool
+Set to
+.Dq Li YES
+if you want to run
+.Nm zpool Cm list
+on your
+.Xr zfs 8
+pools.
+Requires
+.Va daily_status_zfs_enable
+to be set to
+.Li YES .
 .It Va daily_status_ata_raid_enable
 .Pq Vt bool
 Set to



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201202080008.q1808LlN013493>