From owner-svn-ports-head@FreeBSD.ORG  Wed Dec  5 01:49:04 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 9A678B09; Wed,  5 Dec 2012 01:49:04 +0000 (UTC)
Date: Wed, 5 Dec 2012 01:49:04 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Subject: Re: svn commit: r308293 - in head/games: . magicmaze magicmaze/files
Message-ID: <20121205014904.GA46964@FreeBSD.org>
References: <201212050053.qB50r99j019082@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201212050053.qB50r99j019082@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2012 01:49:04 -0000

On Wed, Dec 05, 2012 at 12:53:09AM +0000, Jason Helfman wrote:
> New Revision: 308293
> URL: http://svnweb.freebsd.org/changeset/ports/308293
> 
> @@ -0,0 +1,51 @@
> +# Created by: nemysis@gmx.ch
> +#
> +# $FreeBSD$
> +#

This is non-standard header.  Please see official portmgr@ announcement or
other ports that were correctly converted.

> +DESKTOP_ENTRIES="Magic Maze" "${COMMENT}" "${PORTNAME}" \
> +		"${PORTNAME}" "Game;ArcadeGame;" ${FALSE}

fd.org spec requires startup notification be either "true" or "false"; we
should not rely on the fact that make(1) will provide matching names.  I
suggest using plain "false" here (without the quotes).  Yes, I know that
it causes portlint warning; portlint should be patched to handle
DESKTOP_ENTRIES case correctly).

> +.if ${PORT_OPTIONS:MDOCS}
> +	${MKDIR} ${DOCSDIR}
> +	${INSTALL_DATA} ${WRKSRC}/README.TXT ${WRKSRC}/doc/BUGS.TXT ${WRKSRC}/doc/TODO.TXT ${DOCSDIR}

Very long line.  You (or submitter) should have explicitly defined PORTDOCS
and then do something like this:

	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/doc/|} ${DOCSDIR}

./danfe