Date: Wed, 5 Dec 2012 01:49:04 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308293 - in head/games: . magicmaze magicmaze/files Message-ID: <20121205014904.GA46964@FreeBSD.org> In-Reply-To: <201212050053.qB50r99j019082@svn.freebsd.org> References: <201212050053.qB50r99j019082@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 05, 2012 at 12:53:09AM +0000, Jason Helfman wrote: > New Revision: 308293 > URL: http://svnweb.freebsd.org/changeset/ports/308293 > > @@ -0,0 +1,51 @@ > +# Created by: nemysis@gmx.ch > +# > +# $FreeBSD$ > +# This is non-standard header. Please see official portmgr@ announcement or other ports that were correctly converted. > +DESKTOP_ENTRIES="Magic Maze" "${COMMENT}" "${PORTNAME}" \ > + "${PORTNAME}" "Game;ArcadeGame;" ${FALSE} fd.org spec requires startup notification be either "true" or "false"; we should not rely on the fact that make(1) will provide matching names. I suggest using plain "false" here (without the quotes). Yes, I know that it causes portlint warning; portlint should be patched to handle DESKTOP_ENTRIES case correctly). > +.if ${PORT_OPTIONS:MDOCS} > + ${MKDIR} ${DOCSDIR} > + ${INSTALL_DATA} ${WRKSRC}/README.TXT ${WRKSRC}/doc/BUGS.TXT ${WRKSRC}/doc/TODO.TXT ${DOCSDIR} Very long line. You (or submitter) should have explicitly defined PORTDOCS and then do something like this: ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/doc/|} ${DOCSDIR} ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121205014904.GA46964>