From owner-freebsd-current@FreeBSD.ORG  Fri Aug 14 15:33:48 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E34FD106564A
	for <freebsd-current@freebsd.org>; Fri, 14 Aug 2009 15:33:48 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id B2AAF8FC15
	for <freebsd-current@freebsd.org>; Fri, 14 Aug 2009 15:33:48 +0000 (UTC)
Received: (from root@localhost)
	by kientzle.com (8.14.3/8.14.3) id n7EFXmaV043376;
	Fri, 14 Aug 2009 08:33:48 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2])
	by kientzle.com with SMTP id 9dax34ubf36sx58hucppe3tm5e;
	Fri, 14 Aug 2009 08:33:48 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4A8583DB.1090507@freebsd.org>
Date: Fri, 14 Aug 2009 08:33:47 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.21) Gecko/20090601 SeaMonkey/1.1.16
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <200903282317.n2SNHIjI015202@svn.freebsd.org>	<4A846206.7010803@FreeBSD.org>
	<200908141004.09354.jhb@freebsd.org>
In-Reply-To: <200908141004.09354.jhb@freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Bjoern A. Zeeb" <bz@freebsd.org>, freebsd-current@freebsd.org,
	Doug Barton <dougb@freebsd.org>
Subject: Re: svn commit: r190514 - head/sys/conf
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2009 15:33:49 -0000

John Baldwin wrote:
> On Thursday 13 August 2009 2:57:10 pm Doug Barton wrote:
>> Bjoern A. Zeeb wrote:
>>> Author: bz
>>> Date: Sat Mar 28 23:17:18 2009
>>> New Revision: 190514
>>> URL: http://svn.freebsd.org/changeset/base/190514
>>>
>>> Log:
>>>   For kernel builds reduce the impact of svnversion, just scanning
>>>   src/sys and not the entire src/ tree.

Performance here I think is a red herring.  This is
really about correctness:  The SVN revision of usr.bin/ls
simply isn't relevant for the kernel build.

>> Also, what problem are we really trying to solve here? With a
>> populated cache it takes on average 5 seconds to run all of src, and
>> just under 1 to do only sys. Is 4 seconds really that important to
>> save? With a dry cache I'm sure it takes a little longer, but has
>> anyone actually measured this?

I just measured over 30 seconds for svnversion against /usr/src and
around 6 for /usr/src/sys (both with cold cache).

> It takes far longer than 5 seconds here against a local SVN repo over NFS.

The repo has nothing to do with it.  svnversion doesn't
talk to the repo.  It only examines the working copy.

Tim