From owner-svn-src-all@freebsd.org Thu Apr 26 00:00:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89098FB35A7 for ; Thu, 26 Apr 2018 00:00:08 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 36ECD6AE02 for ; Thu, 26 Apr 2018 00:00:07 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 87531b13-48e4-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 87531b13-48e4-11e8-b951-f99fef315fd9; Wed, 25 Apr 2018 23:58:20 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w3PNxxRx023211; Wed, 25 Apr 2018 17:59:59 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1524700799.57768.111.camel@freebsd.org> Subject: Re: svn commit: r333010 - head/sys/mips/mips From: Ian Lepore To: Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 25 Apr 2018 17:59:59 -0600 In-Reply-To: <201804251946.w3PJkdkH040243@repo.freebsd.org> References: <201804251946.w3PJkdkH040243@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 00:00:08 -0000 On Wed, 2018-04-25 at 19:46 +0000, Li-Wen Hsu wrote: > Author: lwhsu (ports committer) > Date: Wed Apr 25 19:46:39 2018 > New Revision: 333010 > URL: https://svnweb.freebsd.org/changeset/base/333010 > > Log: >   Fix mips32 build after r332951. >    >   Approved by: jhb > > Modified: >   head/sys/mips/mips/pm_machdep.c > > Modified: head/sys/mips/mips/pm_machdep.c > ============================================================================== > --- head/sys/mips/mips/pm_machdep.c Wed Apr 25 18:59:29 2018 (r333009) > +++ head/sys/mips/mips/pm_machdep.c Wed Apr 25 19:46:39 2018 (r333010) > @@ -264,7 +264,7 @@ ptrace_single_step(struct thread *td) >   va = locr0->pc + 4; >   } >   if (td->td_md.md_ss_addr) { > - printf("SS %s (%d): breakpoint already set at %lx (va %lx)\n", > + printf("SS %s (%d): breakpoint already set at %zx (va %zx)\n", >       p->p_comm, p->p_pid, td->td_md.md_ss_addr, va); /* XXX */ >   error = EFAULT; >   goto out; > @@ -500,7 +500,7 @@ ptrace_clear_single_step(struct thread *td) >   >   if (error != 0) { >   log(LOG_ERR, > -     "SS %s %d: can't restore instruction at %lx: %x\n", > +     "SS %s %d: can't restore instruction at %zx: %x\n", >       p->p_comm, p->p_pid, td->td_md.md_ss_addr, >       td->td_md.md_ss_instr); >   } > This isn't right either.  %z is for size_t values, both md_ss_addr and va are integers and a plain %x should be the right format. -- Ian