From owner-svn-src-all@freebsd.org Wed Sep 18 14:58:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB9F1FF92F; Wed, 18 Sep 2019 14:58:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YNQf555hz4QMH; Wed, 18 Sep 2019 14:58:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x532.google.com with SMTP id a3so4251984pgm.13; Wed, 18 Sep 2019 07:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oZmj3sDnUKRP7unsUf2M8sYTzWergU3a3/7hSqSxa6U=; b=S17ThCIvC/pnA0B4GAQuJVvdyVAHshxdn75SipwhJKD/xsiOiWRGzG1qkWoyfmmWIx j91ai+uREH0hs44k0/t42ppj46IvaQgS7SQ/uFbvxjA/iCHHrs7WUo9irz7X5hSNcWPg eIksoej63l1U7ovdxLuYXP8gabRpuDufwzqmgAuK0y8bJVhtRzSPp07yxEAtnmlbnJSa pFdYem6uKd7HmdOJJoei4d7pfS1L0eHuHcS0cB5eTY7XMMIJAgP6GNt8RjHrkRThE9Ph 9L51LiB2SN1l/hHoaeYssBpdKn7Gj/OF4ye2WzSqYk2j5rzSG1J/H2sXNh0kWE8iNeMl AAuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oZmj3sDnUKRP7unsUf2M8sYTzWergU3a3/7hSqSxa6U=; b=j2n5Rm2YzDGAJ01WjhLfwVgANCv7hGmJdeY4LIqX/zF0TXR8iyySLTTyY4UzJAYTbo /v7HBYFBfRjhpU51t/cRcSZN9g+F0WaCDf1oLy/HGcFDQRH1XN3y38wg6h8GT0z2HFED CWBENNtQ/nSN2EMsIwwQbHAzW0Cx4IaL08xIx+5MUciXD6559sOJH/tLD+60M5AOTSwG JcNWypyzwm2RnwEwAE504a5Hs7+kRNCA/5tieYrHNefc/la6rAbwyACJbBGVTBmuHx24 KojyUydqp7j3lPstVX3rTlhq/D3INA/Wp8A8sNcnPgPfZXNahwkA0Fio1aMPAIpAaLbI GsHg== X-Gm-Message-State: APjAAAW8IrVnb9m+s8/ggSh41Z+3Ub8atwgqgspQ/c/HdTTjm7Jd5X69 qzcgtaX5AhBwHmY9/ZaJYz23iuiY0RY= X-Google-Smtp-Source: APXvYqyXJVXJBPtN8ndexMipG/kyAlS57UwfI0U1+IQPoaeJGRSQBsopBocM4lm5IDB9q8BgmUFf9w== X-Received: by 2002:a62:e416:: with SMTP id r22mr4629623pfh.145.1568818712856; Wed, 18 Sep 2019 07:58:32 -0700 (PDT) Received: from ?IPv6:2607:fb90:8361:37e4:e838:8e5e:c58b:1a9d? ([2607:fb90:8361:37e4:e838:8e5e:c58b:1a9d]) by smtp.gmail.com with ESMTPSA id f6sm5335867pgk.65.2019.09.18.07.58.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 07:58:32 -0700 (PDT) Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r352465 - head/share/mk From: Enji Cooper X-Mailer: iPhone Mail (16G102) In-Reply-To: Date: Wed, 18 Sep 2019 07:58:30 -0700 Cc: Kyle Evans , src-committers , svn-src-all , svn-src-head Message-Id: <775F2D15-84C0-4347-863A-6C35095F39FF@gmail.com> References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> To: Warner Losh X-Rspamd-Queue-Id: 46YNQf555hz4QMH X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=S17ThCIv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::532 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-1.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.07), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 14:58:35 -0000 > On Sep 18, 2019, at 06:53, Warner Losh wrote: >=20 >=20 >=20 >> On Wed, Sep 18, 2019, 1:41 PM Kyle Evans wrote: >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote= : >> > >> > >> > > On Sep 17, 2019, at 18:58, Kyle Evans wrote: >> > > >> > > Author: kevans >> > > Date: Wed Sep 18 01:58:56 2019 >> > > New Revision: 352465 >> > > URL: https://svnweb.freebsd.org/changeset/base/352465 >> > > >> > > Log: >> > > googletest: default-disable on all of MIPS for now >> > > >> > > Parts of the fusefs tests trigger a bug in current versions of llvm:= IR >> > > representation of some routine for the MIPS targets is a function wi= th a >> > > large number of arguments. This then leads the compiler on an hour+ l= ong >> > > goose chase, which is OK if you build the current tree but less-so i= f you're >> > > trying external toolchain or doing a universe build involving mips w= hen it >> > > eventually gets switched over to LLVM. >> > > >> > > Better, accurate details can be found in LLVM PR43263. >> > >> > Uhhhhh... why not do this in tests/sys/... instead? >>=20 >> Because there's still value in being able to easily enable these for >> building/running the complete set of tests through standard build >> infrastructure, but it's not worth adding a knob specifically for the >> fusefs tests. I also prefer the communication of it being an >> off-by-default option and easily deduced from src.conf(5) that this >> part of the build is default-disabled on mips/mips. >=20 >=20 > This is the right way to do this, imho... I disagree: disabling a framework and all tests dependent on it because of c= ompile times for a single test suite is the wrong approach. I would complain= more loudly (for instance), if MK_TESTS were disabled on mips, just because= of a build or test issue with a single test. This change throws the baby out with the bath water. The only reason why I=E2= =80=99m not asking for a revert is that mips is a tier 2 arch which I haven=E2= =80=99t verified, and the bath tub that=E2=80=99s being emptied is small, as= many folks haven=E2=80=99t written GoogleTest tests yet in the src tree. -Enji=