From owner-freebsd-current@FreeBSD.ORG Fri Jun 20 05:04:17 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6892E37B401; Fri, 20 Jun 2003 05:04:17 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by mx1.FreeBSD.org (Postfix) with ESMTP id B40E643F75; Fri, 20 Jun 2003 05:04:15 -0700 (PDT) (envelope-from se@freebsd.org) Received: from [212.227.126.161] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 19TKcp-00059b-00; Fri, 20 Jun 2003 14:04:15 +0200 Received: from [80.132.226.22] (helo=Gatekeeper.FreeBSD.org) by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1) id 19TKco-0004Gl-00; Fri, 20 Jun 2003 14:04:14 +0200 Received: from StefanEsser.FreeBSD.org (StefanEsser [10.0.0.1]) by Gatekeeper.FreeBSD.org (Postfix) with ESMTP id 0DF846040; Fri, 20 Jun 2003 14:04:12 +0200 (CEST) Received: by StefanEsser.FreeBSD.org (Postfix, from userid 200) id DD5CC2204; Fri, 20 Jun 2003 14:04:11 +0200 (CEST) Date: Fri, 20 Jun 2003 14:04:11 +0200 From: Stefan =?iso-8859-1?Q?E=DFer?= To: Don Lewis Message-ID: <20030620120411.GA3647@StefanEsser.FreeBSD.org> Mail-Followup-To: Stefan =?iso-8859-1?Q?E=DFer?= , Don Lewis , chris@Shenton.Org, current@FreeBSD.org References: <20030619093146.GA1489@StefanEsser.FreeBSD.org> <200306191513.h5JFDIM7057641@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200306191513.h5JFDIM7057641@gw.catspoiler.org> User-Agent: Mutt/1.5.4i cc: chris@Shenton.Org cc: current@FreeBSD.org Subject: Re: 5.1-CURRENT hangs on disk i/o? sysctl_old_user() non-sleepable locks X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2003 12:04:17 -0000 On 2003-06-19 08:13 -0700, Don Lewis wrote: > > In PR kern/46652 I reported, that DEBUG_VFS_LOCKS does never > > check the **vpp parameters. A patch is included in the PR and > > it does generate the missing tests. > > > > I asked for feedback on the hackers mail list (IIRC), but did > > not get any replies. > > > > Any objections against me committing the patch now ? > > > > (A different fix is mentioned in the PR, the patch I suggested > > was the minimal change to the code which made it work, the > > alternative seems cleaner to me ...) Please read PR kern/46652 ! > > I think the alternative fix should be committed. That would do the > correct thing if another pointer to a pointer to a vnode argument is > ever added. I think this is better than adding magic to vpp. Well, the alternative fix is much more work than I thought ... I spent an hour on it, but the parameter names are assumed to only consist of [a-z]* in a number of places and fixing this would add complexity to the AWK script and make it harder to maintain. Instead, I'm going to commit the trivial fix and add a comment about double indirection as in **vpp requiring special code in the AWK script to vnode_if.src ... This will fix the debug code that is generated and who ever cares for a better solution may back-out my two line fix and implement the clean solution. > Any idea if this change turns up more problems? Sorry, no. I found this while looking for some other problem and just opened the PR and sent a note to the hackers mail list ... Regards, STefan