Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Dec 2012 02:00:56 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Jason Helfman <jgh@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308295 - head/databases/adodb5
Message-ID:  <20121205020056.GB46964@FreeBSD.org>
In-Reply-To: <201212050117.qB51H1vJ024041@svn.freebsd.org>
References:  <201212050117.qB51H1vJ024041@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 05, 2012 at 01:17:01AM +0000, Jason Helfman wrote:
> New Revision: 308295
> URL: http://svnweb.freebsd.org/changeset/ports/308295
> 
> @@ -1,15 +1,12 @@
> -# New ports collection makefile for: adodb5
> -# Date created:		25 Dec 2007
> -# Whom:			mm@FreeBSD.org
> +# Created by: mm@FreeBSD.org
>  #
>  # $FreeBSD$
> -#

Header is still incorrect.

> -OPTIONS=	TESTS "Install tests" off
> +OPTIONS_DEFINE=	TESTS
> +TESTS_DESC=	"Install tests"

FOO_DESC should not be quoted.  There are other minor style bugs remain in
the Makefile.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121205020056.GB46964>