From nobody Wed Apr 1 07:29:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4flxTR4713z6W7G6 for ; Wed, 01 Apr 2026 07:30:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4flxTR32YNz3dVh for ; Wed, 01 Apr 2026 07:30:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775028603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ur2IU8iHwZzE3GBKC0K2NA0gTpEUaEDa8uUfBnOXf7o=; b=bsjGkIlM3u9FEOlshPIiWHNkHGDdpiHwTQgACUGqdSWM6isiweZt898wGPDfwHZOLhb3Yx zj8wL0ilbwvPRwY5bOdI6Ogv8oIUfPYX48bENYIIEU9BCRqKaW4izNZgPvybsRb4W+c2XQ EZ2SI/lMu90TS8/diQrwNKrLlgPVSX993+h6bVwxfSgHKJS+0LJTBaET81N1U61trOe8Ms nPlCOzKXqS2DVPlH3xY0HXTcTt1+XM6RDW2eAGzk8ooJiw0VVCuZwiUKu7oTt1wuag3OGo DLT17zNiuqGC5JWhpyEx5TOHRir6Wznsn/H0Zz3sFF6ySds6oS+4qHGah2663A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775028603; a=rsa-sha256; cv=none; b=Dy7tLrKOVsI4NouTFCTAUC+U1EZibMT5vq7OV0xv3L1MF8Yjt67e8VvqVWlrDJ+okQeKSX wTeSaHR7aaB9P++FQNxsII1QYQnxEPp2T2CplWYuB4BiDBzfQRQXDTf+SUiRnQhwtn/QqX DWSL9b+kSNme8XTJhqvaervGmLrTg4xD/9uqdYVZCQZ95vK2HfAtdV9/ils428N5t8Hjdr wDDA+iL/Fm+3NW1HCIBcNbzgG8gw5TA2MkQqSIPp84gq1KGvgtFJxyZQj3L0g2p8IOcPWA +1LXWZdPjWfuxAYGK3tgblA6AmK7qx2D/KDnzgBXc6gHGdywyAMpSM8lSVsK7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775028603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ur2IU8iHwZzE3GBKC0K2NA0gTpEUaEDa8uUfBnOXf7o=; b=ExsMJ+3MMiJnUv9rmfdxXAJUC9DJ4fHP2mDYvXNVMd481/fIrbfZ6v7Bb936JiWxsNyEQd fJt7kZ8dDhXI4DgBso9BtxvhnKlcLJf+PBhDrAwE+SBXIcCwg9seYUAwINPHOiuo9575xW K6HuBLRakz4g2+hHFi57e4H+MYfT2bKgxrDtJIGLcNsZeAjJNGjyKQcuuSCgaOa/p+OzHW DQ+acYfiYsj2RJwy9aLZ6e6KuKLgEOvIL7p094lfrXNuy5Ypyf2Vrjvkgm8Eqdcxr2D1ig XWsvkN1MvQKRTTZdIqYiYDxPX44SKuvQZpoNv9t5GNUkthnlJ2Q+s1ZZh64hTw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4flxTR2M4Tz15Pt for ; Wed, 01 Apr 2026 07:30:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24e0d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 01 Apr 2026 07:29:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Weixie Cui From: Enji Cooper Subject: git: f3b59bf28504 - main - bce: Fix SYSCTL_IN error check in bce_sysctl_nvram_write() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f3b59bf28504f901f4fcb568004a92c02fa371ed Auto-Submitted: auto-generated Date: Wed, 01 Apr 2026 07:29:58 +0000 Message-Id: <69ccc976.24e0d.305fe761@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=f3b59bf28504f901f4fcb568004a92c02fa371ed commit f3b59bf28504f901f4fcb568004a92c02fa371ed Author: Weixie Cui AuthorDate: 2026-03-31 13:51:46 +0000 Commit: Enji Cooper CommitDate: 2026-04-01 07:29:46 +0000 bce: Fix SYSCTL_IN error check in bce_sysctl_nvram_write() The condition after SYSCTL_IN was inverted: success (error == 0) returned immediately and skipped the NVRAM write path, while failure fell through. Return only when SYSCTL_IN fails. Signed-off-by: Weixie Cui Reviewed-by: ngie Pull-Request: https://github.com/freebsd/freebsd-src/pull/2113 --- sys/dev/bce/if_bce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/bce/if_bce.c b/sys/dev/bce/if_bce.c index 6cf39e035ea6..84992af0c6b8 100644 --- a/sys/dev/bce/if_bce.c +++ b/sys/dev/bce/if_bce.c @@ -8861,7 +8861,7 @@ bce_sysctl_nvram_write(SYSCTL_HANDLER_ARGS) bzero(sc->nvram_buf, sc->bce_flash_size); error = SYSCTL_IN(req, sc->nvram_buf, sc->bce_flash_size); - if (error == 0) + if (error != 0) return (error); if (req->newlen == sc->bce_flash_size)