From owner-svn-src-all@freebsd.org Tue Apr 17 00:02:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D74AF886BB; Tue, 17 Apr 2018 00:02:08 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670089.outbound.protection.outlook.com [40.107.67.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2548469326; Tue, 17 Apr 2018 00:02:05 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM (52.132.66.153) by YQBPR0101MB1538.CANPRD01.PROD.OUTLOOK.COM (52.132.69.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.9; Tue, 17 Apr 2018 00:02:04 +0000 Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::893c:efc2:d71f:945a]) by YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::893c:efc2:d71f:945a%13]) with mapi id 15.20.0675.015; Tue, 17 Apr 2018 00:02:04 +0000 From: Rick Macklem To: Julian Elischer , Konstantin Belousov , Andriy Gapon CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r332559 - head/usr.sbin/mountd Thread-Topic: svn commit: r332559 - head/usr.sbin/mountd Thread-Index: AQHT1d2LvqfGyf/rSkGmX+1c3ssiQQ== Date: Tue, 17 Apr 2018 00:02:04 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YQBPR0101MB1538; 7:/Sm3G+mb+OkUPB+A5r50daALVkqrGa7coSrUa1XZG6iI/d8dteiACea8ffg3uR4P9eiA58XEQjP2fMN677DZ8rUJqlmCz7ptGZxfKEv9aXbygMEwrLsepJj/W7KmtiaA0YWfH/eNeboJ4eb6bDPfWfmiQBuDLl6Wmw9+l0seQOQhKvUL4j6CKfL//c8PMFsFr0Nj+jORWNghfq8zmUxAgzk5O9eVlV8n7p5OoX8QsHa4b/BbqBgaP8FZ/qq61MHs x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989080)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(2017052603328)(7153060)(7193020); SRVR:YQBPR0101MB1538; x-ms-traffictypediagnostic: YQBPR0101MB1538: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231232)(944501351)(52105095)(10201501046)(6041310)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:YQBPR0101MB1538; BCL:0; PCL:0; RULEID:; SRVR:YQBPR0101MB1538; x-forefront-prvs: 0645BEB7AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39380400002)(396003)(39860400002)(376002)(189003)(199004)(110136005)(54906003)(6246003)(97736004)(106356001)(486006)(316002)(39060400002)(53936002)(786003)(14454004)(81156014)(81166006)(8676002)(2900100001)(9686003)(8936002)(55016002)(33656002)(68736007)(74482002)(105586002)(186003)(86362001)(6436002)(4326008)(5660300001)(5250100002)(99286004)(478600001)(7696005)(25786009)(102836004)(229853002)(59450400001)(26005)(6346003)(305945005)(74316002)(2906002)(476003)(3660700001)(6506007)(3280700002)(299355004); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1538; H:YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-microsoft-antispam-message-info: yGi9dmIPN5AnSKcGhbKKFuOzf7uNUN1GUZ0yTUh9vi8knJ6bKs3kJM3GgyfS3FxH4OYH2XqoKNH3QxOB+lsNk2Rl0oYVJ6H3bOeVvedcoTdsDKbdSmFQxw3d8W/qNP7ye6KJYZ0co8wsnsxKq2PSAgq7I+kKafI4lbElD08MahZPmuBPKlgszEuFT5KX8KEY spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 48b5e24a-aa9f-4df5-ad43-08d5a3f67418 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 48b5e24a-aa9f-4df5-ad43-08d5a3f67418 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2018 00:02:04.7537 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1538 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 00:02:08 -0000 I wrote: >Julian Elischer wrote: >>On 16/4/18 6:56 pm, Konstantin Belousov wrote: >[stuff snipped] >>>> + ngroups =3D3D XU_NGROUPS + 1; >>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >>valid question.. because that is how many are allocated? >>it was a "minimally invasive patch".. whoever used XU_NGROUPS before >>should have fixed it. >>Having said that, thanks for drawing out attention to it.. will >>probably fix. >16 is the limit specified in the RFCs for Sun RPC, so that is the "on the = wire" limit. >I haven't looked at the code. It might make sense to handle more here and = then >set the limit at 16 after getting rid of duplicates, but I have no idea if= =3D >it matters? > >rick Correcting my own post. Now that I've looked at the code, this doesn't go o= n the wire. It does go in the exports structure, which means that this struct= ure would have to be revised (along with the syscall and VOP calls and the kern= el code that uses it). These credentials are for the "maproot/mapall" export option and revising the export structure seems like quite a bit of work for= this case. (Until revised XU_NGROUPS is the correct value to set it to, since th= ere is a "struct xucred" in the exports structure.) Since Julian Elischer has been emailing me about adding a "fsid" export opt= ion which allows /etc/exports to set the FSID of the exported fs (which would a= lso need to go in the exports structure), it might be about time to rev. the ex= ports structure? rick=