From owner-svn-src-head@FreeBSD.ORG Sun Jun 7 17:06:56 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E16236FF; Sun, 7 Jun 2015 17:06:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pd0-x235.google.com (mail-pd0-x235.google.com [IPv6:2607:f8b0:400e:c02::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B0DEB1C18; Sun, 7 Jun 2015 17:06:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pdbki1 with SMTP id ki1so85755936pdb.1; Sun, 07 Jun 2015 10:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=3b8k5eEkL2OLrxi4naeOOy53I6f475uRqoCZGhUGHV8=; b=rNbGr24xnika8MpxFN9Gu4ugS7iuhqto7xuGa3r58gGC2K82zbFDlt0IUzUtkiXllZ 50QHsAHD5O1mLQIOVHnofdtjWS2V1cwaZ9q/tVpuGFReKF1AHAE1iEnskoXyIekuQytO p6gxv3dsK8tj36FaHlt0lk8EmRAjFyEDkWkCUWWHK+06baM3Y6BMRHcVPFcu2nN4/Gt+ wIJ7NHs4E1/tD+mJy1vtKjDFvTaB5F5YzJw4DLfhSFWlNx+qF8Ti64fPaPdvlYxoDW89 x7KLQdQrnQ+R7jhoBQXr0ZQqOj6q04/7HmNl3MHus8QIRs8B3feuawWgQ7IwlWYvBzWV ldnA== X-Received: by 10.66.145.133 with SMTP id su5mr22341567pab.114.1433696816123; Sun, 07 Jun 2015 10:06:56 -0700 (PDT) Received: from [192.168.20.7] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id k9sm141063pdp.60.2015.06.07.10.06.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 07 Jun 2015 10:06:55 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r284116 - head/sys/boot/ficl From: Garrett Cooper X-Mailer: iPhone Mail (12F70) In-Reply-To: <201506071420.t57EKnio083109@svn.freebsd.org> Date: Sun, 7 Jun 2015 10:06:54 -0700 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <5F622B98-A1AE-41FB-8E4A-E767DB928689@gmail.com> References: <201506071420.t57EKnio083109@svn.freebsd.org> To: Marcelo Araujo X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2015 17:06:57 -0000 > On Jun 7, 2015, at 07:20, Marcelo Araujo wrote: >=20 > Author: araujo (ports committer) > Date: Sun Jun 7 14:20:48 2015 > New Revision: 284116 > URL: https://svnweb.freebsd.org/changeset/base/284116 >=20 > Log: > Include header libi386.h to silence the clang warning of implicit declara= tion > of functions biospci_*. >=20 > Differential Revision: D2668 > Reviewed by: rodrigc >=20 > Modified: > head/sys/boot/ficl/loader.c >=20 > Modified: head/sys/boot/ficl/loader.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/boot/ficl/loader.c Sun Jun 7 13:59:02 2015 (r284115) > +++ head/sys/boot/ficl/loader.c Sun Jun 7 14:20:48 2015 (r284116) > @@ -46,6 +46,7 @@ > #include "bootstrap.h" > #include > #include "ficl.h" > +#include "../i386/libi386/libi386.h" Hi Marcelo, This commit's explicitly polluting the ficl interpreter with code from x86 o= n all platforms. Seems like the code should be refactored to not explicitly i= nclude this symbol, then #include this header there. That's the real bug.. Also, I'm not a huge fan of relative #include's. I prefer using CFLAGS with -= I (mostly personal preference, however I think it affects file generation to= o). Thanks!=