From owner-freebsd-mips@FreeBSD.ORG Thu Jun 18 03:59:42 2015 Return-Path: Delivered-To: freebsd-mips@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A09546F; Thu, 18 Jun 2015 03:59:42 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5E9AFD6C; Thu, 18 Jun 2015 03:59:42 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qkbp125 with SMTP id p125so33530692qkb.2; Wed, 17 Jun 2015 20:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=RDB9dTpt6f6/5aRJ0B0/lAAuEGtQpH8PiX/9Bkk54y8=; b=OEh6dAevMpezSTCBi0zr/VTqiZZLxW5LbGbn2O85HsvbMgiaGajbclvZW9SMOSFKiR SJ5HNpXWLp8qhk5lX9j9NQaBJzMFJ7NOhrOrromhKRHWEnlafz+jTJ4e9vDSXqpRxX1H tVYgteusENUK9bRGNEgbaq1Ye4Igk/sV/mtK7AMJb24j+cdwqD7gbzaO2yrkt385/4FH Etq23Rv9NtRUYQO9Zfg18G0jJMXjAaPg2yLoDV8UBfCsifnykijxbMPOhUOC6Zw4rYtI UQgXduGY03um9mpJGdxAZ0+7/QZg+pPkJ2WK22mj3E8VjWUPYPyegYM/oAqBSmYUg9b7 6rnQ== X-Received: by 10.140.27.211 with SMTP id 77mr12040792qgx.64.1434599981380; Wed, 17 Jun 2015 20:59:41 -0700 (PDT) Received: from kan ([2601:18f:0:1570:226:18ff:fe00:232e]) by mx.google.com with ESMTPSA id 140sm3263825qhg.16.2015.06.17.20.59.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2015 20:59:40 -0700 (PDT) Date: Wed, 17 Jun 2015 23:59:34 -0400 From: Alexander Kabaev To: Adrian Chadd Cc: "freebsd-mips@freebsd.org" Subject: Re: [rfc] fix umul_ppmm() in our libgcc Message-ID: <20150617235934.3d2c4c95@kan> In-Reply-To: References: <20150616011832.146e0f0e@kan> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/0HSCHw2_GhpySvTaZ6gGh2G"; protocol="application/pgp-signature" X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 03:59:42 -0000 --Sig_/0HSCHw2_GhpySvTaZ6gGh2G Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 17 Jun 2015 19:57:35 -0700 Adrian Chadd wrote: > Ok, so this: >=20 > adrian@lucy-11i386:~/work/freebsd/head-embedded-2/src/contrib/gcc % > svn diff longlong.h > Index: longlong.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- longlong.h (revision 284394) > +++ longlong.h (working copy) > @@ -584,11 +584,11 @@ >=20 > #if defined (__mips__) && W_TYPE_SIZE =3D=3D 32 > #define umul_ppmm(w1, w0, u, v) \ > - __asm__ ("multu %2,%3" \ > - : "=3Dl" ((USItype) (w0)), \ > - "=3Dh" ((USItype) (w1)) \ > - : "d" ((USItype) (u)), \ > - "d" ((USItype) (v))) > + do { \ > + UDItype __x =3D (UDItype) (USItype) (u) * (USItype) (v); \ > + w1 =3D __x >> 32; \ > + w0 =3D __x; \ > + } while (0) > #define UMUL_TIME 10 > #define UDIV_TIME 100 > #endif /* __mips__ */ >=20 >=20 > ? >=20 >=20 >=20 > -a Looks good to me. --=20 Alexander Kabaev --Sig_/0HSCHw2_GhpySvTaZ6gGh2G Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJVgkInXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5++h4QAJGIEjyUtroOviLOqKPpn6JM tmyzbyW1hJg45hNlYuNRZQjSLWCSul7W7ajtqLhdA/LZCoiGtSg7ACn3j0olaJK3 lPeevMJWFIavpZVA0yCrd19VeV2OvzlLdBdYsMgo5PkguQqDFMPAFZa/JEdl27Lp sWIGsgWY1pQEjxWbhxIvxhCsQGfgTUU6ZLPU6o0tomKV50rev2lDWhuJ9uYXgGj4 wVy765UacjA8Vrl/fqhHacEuIJq/0KR8nt5o1jDFGg0WIuJUlHrxFxDvD7EPAz6r ZdYsv7eA2/M2eFLHP2Ldmb5JBlW8ytOPxB4gndch6j6TF4H30OSs6jcBC4utl0wK 7VMFHzlnKLvwes7jFH8ke79A9L0M7ibhvSiNNcyiLmHIv99vpQ6O5u+jprDrBu+T ab9gkY1nR33sWzkxF6Ue1gxSd7LnAPd2I6nnyHV3YMUp/2w7R9h20Ou4+aLQguu9 760jOBDRByK1n25dStT0cvNivZFNfbKbZjiTG/1dQyMSEonataZbWC9lzwyn10gi P+PSIciHvAdv0h8qigw+m1tmFgG2RR+5CnlxlqsAxsmb3F2dkvL9LTYyfVf8l4YU Mt0efIrkyCQTZlHzWuwXC04BoC2zFrQkf5G/1VcjiMnJvYQi9n7hgmk8TPDLNhrC AphKJNzf2lFYLTsrUupX =R2qq -----END PGP SIGNATURE----- --Sig_/0HSCHw2_GhpySvTaZ6gGh2G--